-
Notifications
You must be signed in to change notification settings - Fork 15
Update Github Actions workflow #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
=========================================
Coverage 72.31% 72.31%
Complexity 125 125
=========================================
Files 8 8
Lines 372 372
=========================================
Hits 269 269
Misses 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it works like that:
- it is possible to select
Tests (PHPUnit), but Github Actions aren't being checked on tests selection. - while selecting
Github Actions workflow,Tests (PHPUnit)got selected as well, but it is possible to unselect it manually andGithub Actions workflowstill stays selected. - while selecting
Github Actions custom workflow,Github Actions workflowandTests (PHPUnit)got selected both (it seems that 2 Github Actions workflow files is redandant), also it is possible to manually unselect any of those as all checkboxes are always not disabled.
|
Correct |
|
Actually thing to do is like we do with services. Eliminate the dependency requirement and instead include the GitHub actions file with the tests output so one always gets made when tests are selected. |
Update GA workflow to allow choosing orig full workflow or simple reusable workflow.
Remove Travis workflows
Give the UI better help options