Skip to content

Conversation

@iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Apr 27, 2025

Update GA workflow to allow choosing orig full workflow or simple reusable workflow.
Remove Travis workflows
Give the UI better help options

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (88c2456) to head (dffccd1).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #152   +/-   ##
=========================================
  Coverage     72.31%   72.31%           
  Complexity      125      125           
=========================================
  Files             8        8           
  Lines           372      372           
=========================================
  Hits            269      269           
  Misses          103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iMattPro iMattPro requested a review from rxu April 28, 2025 19:42
Copy link
Contributor

@rxu rxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it works like that:

  • it is possible to select Tests (PHPUnit), but Github Actions aren't being checked on tests selection.
  • while selecting Github Actions workflow, Tests (PHPUnit) got selected as well, but it is possible to unselect it manually and Github Actions workflow still stays selected.
  • while selecting Github Actions custom workflow, Github Actions workflow and Tests (PHPUnit) got selected both (it seems that 2 Github Actions workflow files is redandant), also it is possible to manually unselect any of those as all checkboxes are always not disabled.

@iMattPro
Copy link
Contributor Author

Correct

@iMattPro
Copy link
Contributor Author

Actually thing to do is like we do with services. Eliminate the dependency requirement and instead include the GitHub actions file with the tests output so one always gets made when tests are selected.

@iMattPro iMattPro merged commit b1d6dce into phpbb-extensions:master Apr 30, 2025
34 checks passed
@iMattPro iMattPro deleted the update branch April 30, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants