Fix negative offset false positive on constant string #3784
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug report is about an error, the regression test should be in RuleTestCase. |
staabm
commented
Jan 16, 2025
| if ($offsetType instanceof ConstantIntegerType) { | ||
| if ($offsetType->getValue() < strlen($this->value)) { | ||
| if ($strLenType->isSuperTypeOf($offsetType)->yes()) { | ||
| return new self($this->value[$offsetType->getValue()]); |
There was a problem hiding this comment.
this change also fixes a php warning which could happen on too small negative offsets (covered by the tests)
staabm
force-pushed
the
bug12122
branch
2 times, most recently
from
89c7f69 to
f5c2054
Compare
ondrejmirtes
requested changes
Jan 24, 2025
| @@ -366,7 +366,7 @@ public function isUppercaseString(): TrinaryLogic | |||
| public function hasOffsetValueType(Type $offsetType): TrinaryLogic | |||
| { | |||
| if ($offsetType->isInteger()->yes()) { | |||
| $strLenType = IntegerRangeType::fromInterval(0, strlen($this->value) - 1); | |||
| $strLenType = IntegerRangeType::fromInterval(-strlen($this->value), strlen($this->value) - 1); | |||
There was a problem hiding this comment.
You know you could ask for strlen() just once :)
staabm
force-pushed
the
bug12122
branch
3 times, most recently
from
feae16d to
7afe44a
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#12122