Allow write access to offsets of readonly ArrayAccess properties #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one sec - will fix to make this work properly with old PHP versions |
|
This pull request has been marked as ready for review. |
|
ok. much better. I don't think the failing rector integration test is related to this at all |
ondrejmirtes
requested changes
Jan 24, 2025
| @@ -89,6 +91,10 @@ public function processNode(Node $node, Scope $scope): array | |||
| continue; | |||
| } | |||
|
|
|||
| if ((new ObjectType(ArrayAccess::class))->isSuperTypeOf($propertyReflection->getNativeType())->yes()) { | |||
| continue; | |||
There was a problem hiding this comment.
This is a wrong fix. You can't say that in general.
If I have private readonly ArrayAcess $a and I do $this->a = new Foo() twice, PHP does not allow that.
There was a problem hiding this comment.
🤦 of course - you're right.
I have pushed a patch to expand the test to test for your case and to also check that we're dealing with a SetOffsetValueTypeExpr
pilif
force-pushed
the
bug-8929
branch
2 times, most recently
from
90de7f8 to
8b59053
Compare
In case a readonly property is an object which implements ArrayAccess, offet accesses to said property are turned into method calls on PHP's side and are allowed even on read-only properties. this fixes phpstan/phpstan#8929
of course just checking for ArrayAccess isn't enough - it's only valid for index assignment operations 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a readonly property is an object which implements ArrayAccess, offet accesses to said property are turned into method calls on PHP's side and are allowed even on read-only properties.
this fixes phpstan/phpstan#8929