Skip to content

Conversation

@VincentLanglet
Copy link
Contributor

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@VincentLanglet
Copy link
Contributor Author

nice catch.

Wasn't easy to understand the issue cause dumpType was displaying numeric-string which is the same than the intersection string&numeric-string.

I dunno if some logic exception should be thrown in some case
For instance an UnionType with an AccessoryType inside ?
Or a call to TypeCombinator::UnionType which returns an AccessoryType ?

@staabm
Copy link
Contributor

staabm commented Nov 11, 2025

I dunno if some logic exception should be thrown in some case
For instance an UnionType with an AccessoryType inside ?
Or a call to TypeCombinator::UnionType which returns an AccessoryType ?

I remember a discussion with ondrey, that we can add a sanity check into TypeCombinator when we can afford a BC break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive: strlen(ltrim(number_format()))

2 participants