fix: correct parallelogram visualization for vector subtraction - #341
Merged
mattqdev merged 1 commit intoJun 6, 2026
Merged
Conversation
|
@iamjaysingh is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
1 task
Collaborator
|
thank you @iamjaysingh ! |
Owner
|
🎉 This PR is included in version 3.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87
The parallelogram subtraction visualization was drawing a spurious line
from the tip of vector A to the tip of vector B, which had no geometric
meaning and made the diagram look broken.
Removed the incorrect p.line() call so the visualization now correctly
shows B and -A as adjacent sides of the parallelogram, with the diagonal
R = B + (-A) as the resultant.