Skip to content

Hi! I noticed Google Search Console couldn't read the sitemap because of a duplicate XML declaration at the very beginning of the file. I've updated sitemap-generator.js so it no longer prepends a duplicate <?xml...?> declaration. I also tested the updated sitemap locally, and it renders perfectly with a single declaration now. Closes #107fix: remove duplicate XML declaration in sitemap#371

Merged
mattqdev merged 2 commits into
physicshub:mainfrom
OzkurtSelcuk:fix/duplicate-xml-declaration
Jul 21, 2026

Conversation

@OzkurtSelcuk

Copy link
Copy Markdown
Contributor

📘 Pull Request Template – PhysicsHub

Thank you for contributing to PhysicsHub!
Please complete the sections below to help us review your pull request efficiently.


🔍 Description

Closes #ISSUE_ID (if applicable)


✅ Checklist

Before requesting a review, please ensure that you have:

  • Verified that the project builds and runs locally (npm run dev)
  • Ensured no ESLint or TypeScript warnings/errors remain
  • Updated documentation, comments, or in-code explanations where needed
  • Verified responsiveness across devices (desktop, tablet, mobile)
  • Followed the CONTRIBUTING.md guidelines

🎨 Visual Changes (if UI-related)

IF CHANGES ARE RELATED TO SIMULATIONS PLEASE SEND A SHORT CLIP ABOUT IT
(OBLIGATORY)


📂 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor / code quality improvement
  • 🎨 UI/UX enhancement
  • 🔒 Security improvement

🧩 Additional Notes for Reviewers

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the PhysicsHub's projects Team on Vercel.

A member of the Team first needs to authorize it.

@mattqdev

Copy link
Copy Markdown
Collaborator

Hey man, sorry for the delay, I completely missed your PR...
You fixes seems really precious can you please fix these conflics, and then i'll merge it instantly
Thank you so much for this

@OzkurtSelcuk

Copy link
Copy Markdown
Contributor Author

Hey @mattqdev, I've resolved all the conflicts! Ready to be merged.

@mattqdev

Copy link
Copy Markdown
Collaborator

thank you!

@mattqdev
mattqdev merged commit b09d4bf into physicshub:main Jul 21, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants