closing and merging #270 #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 14, 2025 17:01
ghost
marked this pull request as draft
ghost
commented
Feb 14, 2025
There was a problem hiding this comment.
Learning: The Gravity Bridge SDK token bridging process requires the following steps:
- Initialize GravityBridgeClient with Ethereum RPC, Cosmos RPC, and private key
- Get ERC-20 contract instance for the token
- Approve Gravity Bridge contract to spend tokens
- Transfer tokens to Gravity Bridge contract
- Wait for Ethereum-side token lock
- Send tokens to recipient on Cosmos chain
Learnt from: bearycool11
URL: https://github.com/bearycool11/PiOS/pull/1
Timestamp: 2025-02-14T22:08:55.602Z
Learning: When implementing Gravity Bridge token transfers, environment variables should be used for sensitive data:
- ETHEREUM_RPC_URL: Ethereum node RPC URL
- COSMOS_RPC_URL: Cosmos node RPC URL
- PRIVATE_KEY: Ethereum private key for signing
- ETHEREUM_ADDRESS: Sender's Ethereum address
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
and yes I need to fix my typo.
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
ghost
approved these changes
Feb 15, 2025
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#270 this is the solution that can help merge this PR.