Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the combination of the 2 fields in "Type" column to allow correct sorting #3207

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Feb 4, 2025

What does this PR aim to accomplish?

Fix a small issue, where the domains are sorted only by the type, but the column actually shows a combination of kind+type, resulting in an apparent unsorted list.

How does this PR accomplish the above?

Uses both fields (kind and type) as data for the column, allowing the correct sort.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

to allow correct sorting

Signed-off-by: RD WebDesign <[email protected]>
@rdwebdesign rdwebdesign requested review from yubiuser and a team February 4, 2025 20:37
@rdwebdesign rdwebdesign merged commit 65ad66d into development Feb 4, 2025
10 checks passed
@rdwebdesign rdwebdesign deleted the fix/domain_sort branch February 4, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants