Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hard-coded time range from graphic titles #3256

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix the graphic titles removing the hard-coded "24h".

image
image

This is the default value, but users can set different time ranges and the hard-coded text could lead to confusion.

This PR complements the changes made in FTL: pi-hole/FTL#2275


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign merged commit 3cdce06 into development Feb 24, 2025
10 checks passed
@rdwebdesign rdwebdesign deleted the fix/graphics_titles branch February 24, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the graphics time range when maxHistory is different than 86400s (24h)
2 participants