Qti3 extractors #36
Merged
Qti3 extractors #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #35 test failures by addressing version detection and extractor logic issues. **Issues Fixed:** 1. QTI 3.0 version detection not recognizing fragment elements 2. Broken canHandle methods after refactoring 3. Missing QTI 3.0 element name checks in extractors 4. Registry API not converting element types to canonical form **Changes:** Version Detection (detectQtiVersion.ts): - Enhanced to recognize any qti- prefixed element as QTI 3.0 - Added regex pattern for kebab-case QTI 3.0 elements in string detection Extractor canHandle Methods: - Reverted 14 extractors to check element.rawTagName (proper validation) - Added QTI 3.0 kebab-case element name checks for 3 extractors: - textEntryExtractor: checks both 'textEntryInteraction' and 'qti-text-entry-interaction' - extendedTextExtractor: checks both camelCase and kebab-case - matchExtractor: checks both camelCase and kebab-case Registry API (ExtractionRegistry.ts): - Fixed getExtractorsForType() to convert input to canonical form Tests (qti3-attribute-extraction.test.ts): - Fixed querySelector calls to use lowercase for HTML parser compatibility **Test Results:** ✅ All 1568 tests passing (previously 10 failures) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.