Skip to content

NullPointerException threw when parsing some useragent value. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyongSik-Yoon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NullPointerException threw when parsing some useragent value. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a403a8c
- Add to junit library for testing.
KyongSik-Yoon Nov 6, 2017
5c0e33b
Simple fix - Ensure not occurring to NullPointerException.ˆ
KyongSik-Yoon Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<junit.version>4.11</junit.version>
</properties>
<build>
<plugins>
Expand All @@ -61,6 +62,15 @@
</execution>
</executions>
</plugin>

</plugins>
</build>
<dependencies>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
</project>
5 changes: 3 additions & 2 deletions src/main/java/net/pieroxy/ua/detection/UserAgentDetectionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package net.pieroxy.ua.detection;
import java.io.*;
import java.util.*;

class UserAgentDetectionHelper {

public static void consumeMozilla(UserAgentContext context) {
Expand Down Expand Up @@ -54,6 +53,8 @@ public static void addExtensionsCommonForLibs(UserAgentContext context, UserAgen
}

public static boolean greaterThan(String integer, int target) {
if (integer == null || integer.length() == 0)
return false;
String beginning = integer;
for (int i=0 ; i<integer.length() ; i++) {
if (Character.isDigit(integer.charAt(i))) continue;
Expand Down
16 changes: 16 additions & 0 deletions src/main/test/net/pieroxy/ua/tooling/UserAgentDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package net.pieroxy.ua.tooling;

import net.pieroxy.ua.detection.UserAgentDetector;
import org.junit.Test;

/**
* @author sam
*/
public class UserAgentDetectorTest {
@Test
public void testEnsureNullPointerExceptionBugFixed() {
String userAgent = "Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5 Build/MMB29Q; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/48.0.2564.106 Mobile Safari/537.36 MobileApp/1.0 (Android; 4.0.3; com.ebay.kr.g9)";
UserAgentDetector detector = new UserAgentDetector();
detector.parseUserAgent(userAgent);
}
}