Skip to content

Conversation

@schulzjona
Copy link

Resolves #546

This adds the possibility to add a version parameter to the GraphQL Query to retrieve specific versions of:

  • Assets
  • Objects
  • Documents

@github-actions
Copy link

github-actions bot commented Feb 19, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@schulzjona schulzjona changed the title [IMPROVEMENT] Add possibility to retrieve specific versions [Improvement] Add possibility to retrieve specific versions Feb 25, 2025
@ghost ghost added the Pimcore:Backlog label Mar 4, 2025
@ghost ghost assigned kingjia90 Mar 4, 2025
@robertSt7 robertSt7 assigned robertSt7 and unassigned kingjia90 Mar 12, 2025
@robertSt7
Copy link
Contributor

@schulzjona With Assets this works fine for me, but with Documents and DataObjects I always get the data from the latest version. Could you please take a look at this? Thanks

@schulzjona
Copy link
Author

👍

@sonarqubecloud
Copy link

@schulzjona
Copy link
Author

schulzjona commented Mar 13, 2025

image @robertSt7 Can u please check if this is checked in your Security Definition? When it is checked it always returns latest versions data

@robertSt7
Copy link
Contributor

image @robertSt7 Can u please check if this is checked in your Security Definition? When it is checked it always returns latest versions data

@schulzjona This isn't checked in my config. Can you please try to query the modificationDate of an object and see if it works for you? Thanks


public function disableVersionedRequests(): bool|string
{
return $this->configuration['security']['disableVersionedRequests'] ?? false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for safety reasons, shouldn't this default to true?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is probably right!

@schulzjona
Copy link
Author

Had some pretty busy weeks. Looking forward to continue work on this during this week/weekend 👍

@schulzjona
Copy link
Author

Closing this for now as I'm currently unable to dedicate the necessary time. I might revisit and rework this in the future, but until then, I don't want to unnecessarily clutter the PR list.

@schulzjona schulzjona closed this Apr 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: GraphQL, get specific versions

4 participants