[Bug]: Call to undefined method when using a "load DataObject" pipeli…

…ne (#272) * fixed loadBy attribute issue Co-authored-by: Alexander Scheider <[email protected]> * Apply php-cs-fixer changes Co-authored-by: Alexander Scheider <[email protected]> Co-authored-by: Corepex <[email protected]>
pimcore · Nov 23, 2022 · 91a98cf · 91a98cf
1 parent 4db1b84
commit 91a98cf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/Mapping/Type/TransformationDataTypeService.php b/src/Mapping/Type/TransformationDataTypeService.php
@@ -229,8 +229,8 @@ public function getPimcoreDataTypes(string $classId, $transformationTargetType,
                     'title' => 'SYSTEM Key',
                     'localized' => false
                 ];
-                $attributes['fullpath'] = [
-                    'key' => 'fullpath',
+                $attributes['path'] = [
+                    'key' => 'path',
                     'title' => 'SYSTEM Fullpath',
                     'localized' => false
                 ];

diff --git a/src/Resources/public/js/pimcore/configuration/components/mapping/operator/loadDataObject.js b/src/Resources/public/js/pimcore/configuration/components/mapping/operator/loadDataObject.js
@@ -99,7 +99,7 @@ pimcore.plugin.pimcoreDataImporterBundle.configuration.components.mapping.operat
             }
         });
 
-        const systemAttributes = ['id', 'fullpath', 'key'];
+        const systemAttributes = ['id', 'path', 'key'];
 
         const partialMatch = Ext.create('Ext.form.field.Checkbox', {
             fieldLabel: t('plugin_pimcore_datahub_data_importer_configpanel_transformation_pipeline_accept_partial_match'),

diff --git a/src/Tool/DataObjectLoader.php b/src/Tool/DataObjectLoader.php
@@ -105,7 +105,13 @@ public function loadByAttribute(string $className,
             if (empty($attributeLanguage) === false) {
                 $element = $className::$getter($identifier, $attributeLanguage, $limit, 0, $objectTypes);
             } else {
-                $element = $className::$getter($identifier, $limit, 0, $objectTypes);
+                if (method_exists($className, $getter)) {
+                    $element = $className::$getter($identifier);
+                }
+
+                if (!$element) {
+                    $element = $className::$getter($identifier, $limit, 0, $objectTypes);
+                }
             }
         } else {
             $queryFieldName = $attributeName;