Fix: Check text against '' to allow zero (#238)

pimcore · Aug 2, 2022 · 92da89b · 92da89b
1 parent dc6b946
commit 92da89b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Mapping/Operator/Simple/StaticText.php b/src/Mapping/Operator/Simple/StaticText.php
@@ -54,7 +54,7 @@ public function process($inputData, bool $dryRun = false)
             $inputData = [$inputData];
         }
 
-        if ($this->text) {
+        if ($this->text !== '') {
             foreach ($inputData as &$data) {
                 if (!empty($data) || $this->alwaysAdd) {
                     switch ($this->mode) {

diff --git a/tests/unit/SimpleOperatorTest.php b/tests/unit/SimpleOperatorTest.php
@@ -2,6 +2,7 @@
 namespace Pimcore\Bundle\DataImporterBundle\Tests;
 
 use Pimcore\Bundle\DataImporterBundle\Exception\InvalidConfigurationException;
+use Pimcore\Bundle\DataImporterBundle\Mapping\Operator\Simple\StaticText;
 use Pimcore\Bundle\DataImporterBundle\Mapping\Operator\Simple\StringReplace;
 use Pimcore\Tests\Util\TestHelper;
 
@@ -82,4 +83,19 @@ public function testStringReplaceProcessFunctionWithEmptyInArray() {
         $this->assertEquals($data[1], "");
         $this->assertEquals($data[2], "");
     }
+
+    public function testStaticTextProcessFunctionWithZero() {
+        $service = $this->tester->grabService(StaticText::class);
+        $service->setSettings(['mode' => StaticText::MODE_APPEND, 'text' => '0', 'alwaysAdd' => false]);
+        $data = $service->process("Test");
+
+        $this->assertEquals("Test0", $data);
+    }
+    public function testStaticTextProcessFunctionWithZeroAndAlwaysAdd() {
+        $service = $this->tester->grabService(StaticText::class);
+        $service->setSettings(['mode' => StaticText::MODE_APPEND, 'text' => '0', 'alwaysAdd' => true]);
+        $data = $service->process("");
+
+        $this->assertEquals("0", $data);
+    }
 }