-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ObjectField Operator for extracting fields from Data Objects. #436
Open
cancan101
wants to merge
5
commits into
pimcore:1.x
Choose a base branch
from
cancan101:feature/ObjectField
base: 1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
<?php | ||
|
||
/** | ||
* Pimcore | ||
* | ||
* This source file is available under two different licenses: | ||
* - GNU General Public License version 3 (GPLv3) | ||
* - Pimcore Commercial License (PCL) | ||
* Full copyright and license information is available in | ||
* LICENSE.md which is distributed with this source code. | ||
* | ||
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org) | ||
* @license http://www.pimcore.org/license GPLv3 and PCL | ||
*/ | ||
|
||
namespace Pimcore\Bundle\DataImporterBundle\Mapping\Operator\Simple; | ||
|
||
use Pimcore\Bundle\DataImporterBundle\Exception\InvalidConfigurationException; | ||
use Pimcore\Bundle\DataImporterBundle\Mapping\Operator\AbstractOperator; | ||
use Pimcore\Bundle\DataImporterBundle\Mapping\Type\TransformationDataTypeService; | ||
use Pimcore\Model\Element\ElementInterface; | ||
|
||
|
||
class ObjectField extends AbstractOperator | ||
{ | ||
private string $attribute; | ||
|
||
private string $forwardParameter; | ||
|
||
public function setSettings(array $settings): void | ||
{ | ||
// are there better defautls than empty string? | ||
$this->attribute = $settings['attribute'] ?? ''; | ||
$this->forwardParameter = $settings['forwardParameter'] ?? ''; | ||
} | ||
|
||
public function process(mixed $inputData, bool $dryRun = false): mixed | ||
{ | ||
if (!$inputData instanceof ElementInterface) { | ||
// is this how to handle type mismatch? | ||
return null; | ||
} | ||
|
||
if (!$this->attribute) { | ||
// is this how to handle no attrinute | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see comment above |
||
return null; | ||
} | ||
|
||
// better to pull full logic from ObjectFieldGetter / AnyGetter | ||
$getter = 'get' . ucfirst($this->attribute); | ||
|
||
if (!method_exists($inputData, $getter)) { | ||
// is there a better default here? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see comment above |
||
return null; | ||
} | ||
|
||
if ($this->forwardParameter) { | ||
$value = $inputData->$getter($this->forwardParameter); | ||
} else { | ||
$value = $inputData->$getter(); | ||
} | ||
|
||
// this expands paths | ||
if ($value instanceof ElementInterface) { | ||
$value = $value->getFullPath(); | ||
} | ||
|
||
return $value; | ||
} | ||
|
||
/** | ||
* | ||
* @throws InvalidConfigurationException | ||
*/ | ||
public function evaluateReturnType(string $inputType, ?int $index = null): string | ||
{ | ||
if ($inputType === TransformationDataTypeService::DATA_OBJECT) { | ||
// for numerics? | ||
return TransformationDataTypeService::DEFAULT_TYPE; | ||
} else { | ||
throw new InvalidConfigurationException( | ||
sprintf( | ||
"Unsupported input type '%s' for load data object operator at transformation position %s", | ||
$inputType, | ||
$index | ||
) | ||
); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/Resources/public/js/pimcore/configuration/components/mapping/operator/objectField.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* Pimcore | ||
* | ||
* This source file is available under two different licenses: | ||
* - GNU General Public License version 3 (GPLv3) | ||
* - Pimcore Commercial License (PCL) | ||
* Full copyright and license information is available in | ||
* LICENSE.md which is distributed with this source code. | ||
* | ||
* @copyright Copyright (c) Pimcore GmbH (http://www.pimcore.org) | ||
* @license http://www.pimcore.org/license GPLv3 and PCL | ||
*/ | ||
|
||
pimcore.registerNS("pimcore.plugin.pimcoreDataImporterBundle.configuration.components.mapping.operator.objectField"); | ||
pimcore.plugin.pimcoreDataImporterBundle.configuration.components.mapping.operator.objectField = Class.create(pimcore.plugin.pimcoreDataImporterBundle.configuration.components.mapping.abstractOperator, { | ||
|
||
type: 'objectField', | ||
|
||
getMenuGroup: function() { | ||
return this.menuGroups.dataManipulation; | ||
}, | ||
|
||
getIconClass: function() { | ||
return "pimcore_nav_icon_object pimcore_icon_overlay_add"; | ||
}, | ||
|
||
getFormItems: function() { | ||
return [ | ||
{ | ||
xtype: 'textfield', | ||
fieldLabel: t('attribute'), | ||
value: this.data.settings ? this.data.settings.attribute : '', | ||
name: 'settings.attribute', | ||
listeners: { | ||
change: this.inputChangePreviewUpdate.bind(this) | ||
} | ||
}, | ||
|
||
{ | ||
xtype: 'textfield', | ||
fieldLabel: t('forward_parameter'), | ||
value: this.data.settings ? this.data.settings.forward_parameter : '', | ||
name: 'settings.forward_parameter', | ||
listeners: { | ||
change: this.inputChangePreviewUpdate.bind(this) | ||
} | ||
}, | ||
]; | ||
} | ||
|
||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, would say this is the best approach.
alternative would be to throw an exception - this is also done here and there.
but I would say, we should also add some notes to the logs, like here for example