fix #100: CHECKSUMS verification with sha256sum fails on Ubuntu 25.10 #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valiko-ua
force-pushed
the
checksum-failure-on-ubuntu25
branch
from
0441ce9 to
65d4744
Compare
valiko-ua
changed the title
Owner
|
Are you sure this change works correctly? Can't remember why exactly but I know I added the debs count check on purpose (which this PR would remove) |
valiko-ua
force-pushed
the
checksum-failure-on-ubuntu25
branch
from
65d4744 to
f081b3c
Compare
Contributor
Author
I tested the fix on Ubuntu 25.10 many times: it works correctly. I also investigated how Of course it would be nice if it was tested on other OS's but I don't have other Linuxes to test. Even if this PR will cause checksum verification failure on some OS, people may file a bug and temporarily use |
Contributor
Author
|
@pimlie Alternatively, to be very cautious, we could use your old approach (check count) for |
Contributor
Author
|
We cannot use counting with |
valiko-ua
force-pushed
the
checksum-failure-on-ubuntu25
branch
from
f081b3c to
729f164
Compare
Owner
|
IIRC the issue is with the So the |
Contributor
Author
|
@pimlie I've just made this test with missing files. If I remove the option So both ways work but the latter one is cleaner in my opinion. |
Contributor
Author
|
Just for the reference, output of |
Contributor
Author
|
Maybe we should preserve old behavior for systems where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #100: Try shasum first.