resource control: support more mode for BURSTABLE #20020

lhy1024 · 2025-03-07T02:45:15Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: lhy1024 <[email protected]>

information-schema/information-schema-resource-groups.md

sql-statements/sql-statement-alter-resource-group.md

sql-statements/sql-statement-create-resource-group.md

Co-authored-by: Roger Song <[email protected]>

ti-chi-bot · 2025-03-12T07:05:35Z

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lhy1024 · 2025-04-27T05:43:05Z

@hfxsd ptal

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot · 2025-06-06T10:21:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

information-schema/information-schema-resource-groups.md

sql-statements/sql-statement-alter-resource-group.md

sql-statements/sql-statement-create-resource-group.md

tidb-resource-control-ru-groups.md

Co-authored-by: Lilian Lee <[email protected]>

information-schema/information-schema-resource-groups.md

sql-statements/sql-statement-alter-resource-group.md

sql-statements/sql-statement-create-resource-group.md

lilin90

/lgtm

ti-chi-bot · 2025-06-27T03:00:10Z

[LGTM Timeline notifier]

Timeline:

2025-06-27 03:00:10.607266052 +0000 UTC m=+1018263.330445035: ☑️ agreed by lilin90.

songrijie · 2025-06-27T10:13:08Z

sql-statements/sql-statement-alter-resource-group.md

+---------+------------+----------+----------------+-------------+------------+
+| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE      | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+----------------+-------------+------------+
+| default | UNLIMITED  | MEDIUM   | YES(UNLIMITED) | NULL        | NULL       |


这里 BURSTABLE 是不是就只显示 OFF, UNLIMITED, MODERATED。用括号不太合适。 @lhy1024

要修改显示结果么？不过不知道代码还能不能合进去了

修改一下吧，这个不太符合系统表的习惯。

pingcap/tidb#62053

lhy1024 added 2 commits March 7, 2025 02:18

resource control: support more mode for BURSTABLE

564c3f9

Signed-off-by: lhy1024 <[email protected]>

add more example

8e2dd78

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2025

songrijie self-requested a review March 7, 2025 02:48

fix

c87dcee

Signed-off-by: lhy1024 <[email protected]>

hfxsd added translation/doing This PR’s assignee is translating this PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. and removed missing-translation-status This PR does not have translation status info. labels Mar 10, 2025

hfxsd self-assigned this Mar 10, 2025

songrijie reviewed Mar 12, 2025

View reviewed changes

information-schema/information-schema-resource-groups.md Outdated Show resolved Hide resolved

songrijie reviewed Mar 12, 2025

View reviewed changes

sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved

songrijie reviewed Mar 12, 2025

View reviewed changes

sql-statements/sql-statement-create-resource-group.md Outdated Show resolved Hide resolved

lhy1024 and others added 3 commits March 12, 2025 14:47

Update information-schema/information-schema-resource-groups.md

c553d32

Co-authored-by: Roger Song <[email protected]>

Update sql-statements/sql-statement-alter-resource-group.md

77b5a92

Co-authored-by: Roger Song <[email protected]>

Update sql-statements/sql-statement-create-resource-group.md

df1abc7

Co-authored-by: Roger Song <[email protected]>

songrijie approved these changes Mar 12, 2025

View reviewed changes

hfxsd added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Mar 18, 2025

hfxsd added the v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. label Mar 31, 2025

lilin90 assigned lilin90 and unassigned hfxsd May 29, 2025

lilin90 requested review from lilin90 and hfxsd May 29, 2025 07:53

lhy1024 added 2 commits June 6, 2025 18:20

fix typo

b98db28

Signed-off-by: lhy1024 <[email protected]>

Merge branch 'burstable' of github.com:lhy1024/docs-cn into burstable

d4b0432

lilin90 mentioned this pull request Jun 9, 2025

resource control: support more mode for BURSTABLE pingcap/docs#21138

Open

16 tasks

lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2025

lilin90 reviewed Jun 11, 2025

View reviewed changes

lhy1024 and others added 10 commits June 11, 2025 16:30

Update information-schema/information-schema-resource-groups.md

df0a206

Co-authored-by: Lilian Lee <[email protected]>

Update information-schema/information-schema-resource-groups.md

ac2c3bb

Co-authored-by: Lilian Lee <[email protected]>

Update sql-statements/sql-statement-create-resource-group.md

049c96b

Co-authored-by: Lilian Lee <[email protected]>

Update tidb-resource-control-ru-groups.md

7ea1e6d

Co-authored-by: Lilian Lee <[email protected]>

Update tidb-resource-control-ru-groups.md

e0034c2

Co-authored-by: Lilian Lee <[email protected]>

Update tidb-resource-control-ru-groups.md

f1d3139

Co-authored-by: Lilian Lee <[email protected]>

Update information-schema/information-schema-resource-groups.md

aa316af

Co-authored-by: Lilian Lee <[email protected]>

Update sql-statements/sql-statement-create-resource-group.md

0aa5863

Co-authored-by: Lilian Lee <[email protected]>

Update wording for consistency

ef332af

Remove tabs

ddbafce

lilin90 reviewed Jun 16, 2025

View reviewed changes

information-schema/information-schema-resource-groups.md Show resolved Hide resolved

lilin90 reviewed Jun 26, 2025

View reviewed changes

sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved

Update table format

0c88290

lilin90 reviewed Jun 26, 2025

View reviewed changes

sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved

Update for wording and format consistency

a50ac16

lilin90 reviewed Jun 26, 2025

View reviewed changes

sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved

Update wording for consistency

b105eb3

lilin90 reviewed Jun 26, 2025

View reviewed changes

sql-statements/sql-statement-create-resource-group.md Outdated Show resolved Hide resolved

sql-statements/sql-statement-create-resource-group.md Outdated Show resolved Hide resolved

lilin90 added 2 commits June 26, 2025 18:18

Update format

86159ca

Update for consistency

bd9328e

lilin90 approved these changes Jun 27, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 27, 2025

songrijie reviewed Jun 27, 2025

View reviewed changes

resource control: support more mode for BURSTABLE #20020

Are you sure you want to change the base?

resource control: support more mode for BURSTABLE #20020

Uh oh!

Conversation

lhy1024 commented Mar 7, 2025 • edited by hfxsd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot bot commented Mar 12, 2025

Uh oh!

lhy1024 commented Apr 27, 2025

Uh oh!

ti-chi-bot bot commented Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lilin90 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jun 27, 2025

[LGTM Timeline notifier]

Uh oh!

songrijie Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

lhy1024 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

songrijie Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

lhy1024 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lhy1024 commented Mar 7, 2025 •

edited by hfxsd

Loading