Skip to content

restore: update the definition of the parameter --load-stats and the usage of pitr id map #20346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

restore: update the definition of the parameter --load-stats and the usage of pitr id map #20346

wants to merge 11 commits into from
+34 −2

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented May 19, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Leavrth added 2 commits May 19, 2025 10:43
@Leavrth
draft
6dee38c 
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
fix typos
f93d5a6 
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2025
BornChanger
BornChanger reviewed May 19, 2025
View reviewed changes
BornChanger
BornChanger reviewed May 19, 2025
View reviewed changes
BornChanger
BornChanger reviewed May 19, 2025
View reviewed changes
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. labels May 19, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 19, 2025
@Oreoxmt Oreoxmt assigned Oreoxmt and lilin90 and unassigned Oreoxmt May 19, 2025
@Oreoxmt Oreoxmt requested a review from lilin90 May 19, 2025 03:38
@Leavrth
commit some suggestions
dd8aa2b 
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2025
Leavrth and others added 5 commits May 23, 2025 12:15
@Leavrth @BornChanger
Update br/br-snapshot-manual.md
f6d7401 
Co-authored-by: BornChanger <[email protected]>
@Leavrth
update the parameter
d72d971 
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Merge branch 'load_stats_and_pitr_id_map' of github.com:Leavrth/docs-…
0a92267 
…cn into load_stats_and_pitr_id_map
@Leavrth
add notice
44dd7c0 
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
add notice
adf4a3d 
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth Leavrth mentioned this pull request May 30, 2025
Open
16 tasks
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 30, 2025
@lilin90 lilin90 added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jun 9, 2025
lilin90
lilin90 reviewed Jun 11, 2025
View reviewed changes
br/br-checkpoint-restore.md Outdated
@@ -89,7 +89,11 @@ br 工具暂停 GC 的原理是通过执行 `SET config tikv gc.ratio-threshold

在第一次执行恢复并且进入日志恢复阶段时，br 工具会在恢复集群中创建 `__TiDB_BR_Temporary_Log_Restore_Checkpoint` 数据库，用于记录断点数据，以及这次恢复的上游集群 ID 和恢复的时间范围 `start-ts` 与 `restored-ts`。如果在此阶段恢复失败，重新执行恢复命令时，你需要指定与断点记录相同的 `start-ts` 和 `restored-ts` 参数，否则 br 工具会报错，并提示上游集群 ID 或恢复的时间范围与断点记录不同。如果恢复集群已被清理，你可以手动删除 `__TiDB_BR_Temporary_Log_Restore_Checkpoint` 数据库，然后使用其他备份重试。

在第一次执行恢复并且进入日志恢复阶段前，br 工具会构造出在 `restored-ts` 时间点的上下游集群库表 ID 映射关系，并将其持久化到系统表 `mysql.tidb_pitr_id_map` 中，以避免库表 ID 被重复分配。如果删除 `mysql.tidb_pitr_id_map` 中的数据，可能会导致 PITR 恢复数据不一致。
在第一次执行恢复并且进入日志恢复阶段前，br 工具会构造出在 `restored-ts` 时间点的上下游集群库表 ID 映射关系，并将其持久化到系统表 `mysql.tidb_pitr_id_map` 中，以避免库表 ID 被重复分配。**如果随意删除 `mysql.tidb_pitr_id_map` 中的数据，可能会导致 PITR 恢复数据不一致。**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Line 86 写到“PITR 恢复分为快照恢复和日志恢复两个阶段”，下面这三段看起来像分了三个阶段。请看下是否调整该小节开头的描述，或者这三段的逻辑和呈现？
  • 另外，从字面语义上看，“在第一次执行恢复并且进入日志恢复阶段前”应该放在“在第一次执行恢复并且进入日志恢复阶段时”前面？

Copy link
Contributor Author

@Leavrth Leavrth Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该说第三段是第二段日志恢复阶段中的前面步骤，这一段相当于一个注意的提示

Copy link
Member

@lilin90 lilin90 Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，我在这段开头加了个“注意” 1cf14ca

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@BornChanger BornChanger BornChanger approved these changes

Assignees

@lilin90 lilin90

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leavrth @lilin90 @BornChanger @Oreoxmt