Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace go.uber.org/atomic with sync/atomic #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serprex
Copy link

@serprex serprex commented Jan 15, 2025

raises go version to 1.18

this is a breaking change since consumers will update with errors.RedactLogEnabled.Store(&errors.RedactLogEnable). ideally this wouldn't be exposed & instead there'd be a function errors.SetRedactLogEnabled(...) & even better the enum would be an integer which could then use atomic.Int32 in behind

@serprex
Copy link
Author

serprex commented Jan 15, 2025

(note that modern go.uber.org/atomic uses these atomic types, their String is specialization built on top of Value which is takes interface{} for Load/Store)

https://github.com/uber-go/atomic/blob/v1.11.0/string.go#L26
https://github.com/uber-go/atomic/blob/v1.11.0/value.go#L27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant