Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SchemaName in utils #22659

Closed
xhebox opened this issue Feb 2, 2021 · 2 comments · May be fixed by #22711
Closed

use SchemaName in utils #22659

xhebox opened this issue Feb 2, 2021 · 2 comments · May be fixed by #22711
Assignees
@Tjianke
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.

Comments

@xhebox
Copy link
Contributor

xhebox commented Feb 2, 2021

Development Task

There are util.MetricSchema and other schema names. But there are inline names everywhere, e.g. SQLs in executor/inspection_* are writing the schema name by hands.
@xhebox xhebox added the type/enhancement The issue or PR belongs to an enhancement. label Feb 2, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Feb 2, 2021

/label sig/execution

@ti-srebot ti-srebot added the sig/execution SIG execution label Feb 2, 2021
@Tjianke
Copy link
Contributor

Tjianke commented Feb 3, 2021

/assign @Tjianke

@Tjianke Tjianke mentioned this issue Feb 4, 2021
Open
@xhebox xhebox closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tjianke Tjianke

Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: Fix inline schema name Tjianke/tidb
3 participants
@xhebox @Tjianke @ti-srebot