Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Fix inline schema name #22711

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

executor: Fix inline schema name #22711

wants to merge 25 commits into from

Conversation

Tjianke
Copy link
Contributor

@Tjianke Tjianke commented Feb 3, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #22659

Problem Summary:

What is changed and how it works?

What's Changed:

Replace inline calling of *_schema with util.XXXSchemaName constant.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix inline schema name

@github-actions github-actions bot added the sig/execution SIG execution label Feb 3, 2021
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 3, 2021

/run-all-tests

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

/run-all-tests

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

/run-all-tests

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

/run-unit-test

1 similar comment
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

/run-unit-test

@Tjianke Tjianke marked this pull request as ready for review February 4, 2021 02:41
@Tjianke Tjianke requested a review from a team as a code owner February 4, 2021 02:41
@Tjianke Tjianke requested review from XuHuaiyu and removed request for a team February 4, 2021 02:41
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

@xhebox PTAL, thanks~

@xhebox
Copy link
Contributor

xhebox commented Feb 4, 2021

@Tjianke I am not a reviewer of execution sig. I can review you code, but I can not approve or merge it. You need to find someone else.

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 4, 2021

@Tjianke I am not a reviewer of execution sig. I can review you code, but I can not approve or merge it. You need to find someone else.

I see, thanks for reminding.

@Tjianke Tjianke force-pushed the fixInlineSchemaName branch from 22376d4 to dd8d8ad Compare February 5, 2021 08:34
@Tjianke Tjianke marked this pull request as draft February 5, 2021 08:34
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 5, 2021

/run-all-tests

1 similar comment
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 5, 2021

/run-all-tests

@Tjianke Tjianke force-pushed the fixInlineSchemaName branch from e98f6d3 to 45db78d Compare February 5, 2021 10:00
@Tjianke Tjianke force-pushed the fixInlineSchemaName branch from be9c8df to a31ba87 Compare February 5, 2021 11:10
@Tjianke Tjianke marked this pull request as ready for review February 5, 2021 11:56
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 30, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2021
@ti-chi-bot
Copy link
Member

@Tjianke: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use SchemaName in utils
3 participants
@Tjianke @xhebox @ti-chi-bot