Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: separate signatures for PlusInt #14128

Closed
wants to merge 23 commits into from
Closed

expression: separate signatures for PlusInt #14128

wants to merge 23 commits into from

Conversation

ChiaoTeo
Copy link
Contributor

PCP #13973

What problem does this PR solve?

Separate signatures for PlusInt

What is changed and how it works?

PASS: builtin_arithmetic_test.go:117: testEvaluatorSuite.TestArithmeticPlus     0.000s
OK: 1 passed
PASS
ok      github.com/pingcap/tidb/expression      2.036s

BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntSignedSignedSig-NonVecBuiltinFunc-8       39559             30227 ns/op               0 B/op        0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntUnsignedUnsignedSig-VecBuiltinFunc-8     442977              2546 ns/op               0 B/op        0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntUnsignedUnsignedSig-NonVecBuiltinFunc-8                   47276             25289 ns/op             0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntSignedUnsignedSig-VecBuiltinFunc-8                       330609              3389 ns/op             0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntSignedUnsignedSig-NonVecBuiltinFunc-8                     45415             26058 ns/op             0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntUnsignedSignedSig-VecBuiltinFunc-8                       387561              2881 ns/op             0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusIntUnsignedSignedSig-NonVecBuiltinFunc-8                     43826             26549 ns/op             0 B/op           0 allocs/op

Check List

Tests

  • Unit test

@ChiaoTeo ChiaoTeo requested a review from a team as a code owner December 18, 2019 16:18
@sre-bot
Copy link
Contributor

sre-bot commented Dec 18, 2019

Thanks for your pull request. Pick up issue #13973 and reopen this PR

@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 18, 2019 16:18
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@sre-bot sre-bot closed this Dec 18, 2019
@ChiaoTeo
Copy link
Contributor Author

/reopen

@lonng lonng reopened this Dec 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 100 points.

@ChiaoTeo
Copy link
Contributor Author

Why so many errors ?

breezewish
breezewish reviewed Dec 19, 2019
View reviewed changes
expression/builtin_arithmetic_vec.go

if uint64(lh) > math.MaxUint64-uint64(rh) {
return types.ErrOverflow.GenWithStackByArgs("BIGINT UNSIGNED", fmt.Sprintf("(%s + %s)", b.args[0].String(), b.args[1].String()))
res, _, err := b.plusUnsingedunsinged(lh, rh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should manually inline the implementation to avoid this function call? @qw4990

@ChiaoTeo ChiaoTeo requested a review from lonng December 24, 2019 09:48
@breezewish
Copy link
Member

You need to first modify the protobuf https://github.com/pingcap/tipb to introduce these new signatures.

@ChiaoTeo ChiaoTeo mentioned this pull request Dec 28, 2019
Merged
@zz-jason zz-jason changed the title Separate signatures for PlusInt expression: separate signatures for PlusInt Dec 28, 2019
@ChiaoTeo
Copy link
Contributor Author

You need to first modify the protobuf https://github.com/pingcap/tipb to introduce these new signatures.
I already modify .could you review this change
@breeswish
pingcap/tipb#168

@sre-bot
Copy link
Contributor

sre-bot commented Jan 10, 2020

@zhaoqian888, please update your pull request.

@wshwsh12 wshwsh12 removed their request for review January 14, 2020 06:57
@zz-jason zz-jason requested review from wshwsh12 and removed request for zz-jason February 15, 2020 11:51
@ChiaoTeo
Copy link
Contributor Author

/run-all-tests tikv=pr/6568

@ChiaoTeo
Copy link
Contributor Author

@qw4990

wshwsh12
wshwsh12 approved these changes Feb 16, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 16, 2020

@zhaoqian888 merge failed.

@lonng lonng removed their request for review February 17, 2020 07:15
@ChiaoTeo
Copy link
Contributor Author

ChiaoTeo commented Mar 2, 2020

/run-all-tests tikv=pr/6568

@wshwsh12
Copy link
Contributor

wshwsh12 commented Apr 8, 2020

/merge

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0f30296). Click here to learn what that means.
The diff coverage is n/a.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

@zhaoqian888 merge failed.

@breezewish
Copy link
Member

Sorry, several weeks ago there is a TiKV PR that removes the required signatures by mistake, so that this PR failed. Here is a fix: tikv/tikv#7399

@breezewish
Copy link
Member

/run-all-tests

1 similar comment
@breezewish
Copy link
Member

/run-all-tests

@ti-srebot
Copy link
Contributor

@zhaoqian888, please update your pull request.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-srebot
Copy link
Contributor

@zhaoqian888, please update your pull request.

@ti-srebot
Copy link
Contributor

@zhaoqian888 PR closed due to no update for a long time. Feel free to reopen it anytime.

@ti-srebot ti-srebot closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@zz-jason zz-jason zz-jason left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@breezewish breezewish Awaiting requested review from breezewish

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ChiaoTeo @sre-bot @breezewish @lzmhhh123 @zz-jason @wshwsh12 @ti-srebot @lonng