Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: separated signatures for PlusIntSig #21980

Closed
wants to merge 41 commits into from

Conversation

Tjianke
Copy link
Contributor

@Tjianke Tjianke commented Dec 23, 2020

What problem does this PR solve?

Issue Number: close #13973

Problem Summary:

What is changed and how it works?

What's Changed:

builtin_arithmetic.go

How it Works:

Impl vec, separated func sig from original PlusIntSig

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • separated signatures for builtin PlusIngSig

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 23, 2020
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
24 out of 25 committers have signed the CLA.

✅ Tjianke
✅ ichn-hu
✅ crazycs520
✅ lzmhhh123
✅ LittleFall
✅ gauss1314
✅ wshwsh12
✅ Yisaer
✅ luxinle
✅ TszKitLo40
✅ lysu
✅ eurekaka
✅ erwadba
✅ morgo
✅ xuyifangreeneyes
✅ winoros
✅ JmPotato
✅ xhebox
✅ dyzsr
✅ pingyu
✅ time-and-fate
✅ Reminiscent
✅ xiongjiwei
✅ AilinKid
❌ Jianke Tang


Jianke Tang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 23, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Dec 23, 2020

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@Tjianke Tjianke changed the title separated sigs separated signatures for PlusIntSig Dec 23, 2020
@Tjianke Tjianke changed the title separated signatures for PlusIntSig expression: separated signatures for PlusIntSig Dec 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Dec 24, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2020

eurekaka and others added 21 commits December 25, 2020 13:11
@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2020

@Tjianke Tjianke closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate signatures for PlusInt