expression: separated arithmeticMinusIntSig

[Tjianke]

What problem does this PR solve?

Issue Number:

• closes Separate signatures for PlusInt #13973

Problem Summary:

• Separating ArithmeticMinusIntSig at planning stage will be more efficient then current status

What is changed and how it works?

What's Changed:

• Separated and vectorized old func signature by the signedness of args and sql_mode(NO_UNSIGNED_SUBTRACTION)
• Updated tipb dependency to introduce new func signatures
• Rewrote unit test for arithmeticMinusInt, making it much more easier to add unit tests

How it Works:

• Rewrote dispatch logic in func (c *arithmeticMinusFunctionClass) getFunction(ctx sessionctx.Context, args), introduced 7 new func sig.
• Overflow logic is reused from original vectorized func, except for cases where bugs were found(fixing bugs in expression: fix bugs in builtinfunction ArithmeticMinusInt logic #22426 ).
  • builtinArithmeticMinusIntSignedUnsignedSig
    • Overflow detection loigc: a < 0 || uint64(a) < uint64(b)
  • builtinArithmeticMinusIntUnsignedUnsignedSig
    • Overflow detection logic: uint64(a) > uint64(b)
  • builtinArithmeticMinusIntUnsignedSignedSig
    • Overflow detection logic: (b < 0 && uint64(a) > math.MaxUint64-uint64(-b)) || (b >= 0 && uint64(a) < uint64(b))
  • builtinArithmeticMinusIntSignedSignedSig*(works whether NO_UNSIGNED_SUBTRACTION mode is set or not)
    • Overflow detection logic: (lh >= 0 && rh == math.MinInt64) || (lh > 0 && -rh > math.MaxInt64-lh) || (lh < 0 && -rh < math.MinInt64-lh)
  • builtinArithmeticMinusIntForcedUnsignedUnsignedSig
    • Overflow detection logic: (a > 0 && -b > math.MaxInt64-a) || (a < 0 && -b < math.MinInt64-a)
  • builtinArithmeticMinusIntForcedSignedUnsignedSig
    • Overflow detection logic: (a > 0 && -b > math.MaxInt64-a) || (a < 0 && -b < math.MinInt64-a)
  • builtinArithmeticMinusIntForcedUnsignedSignedSig
    • Overflow detection logic: (a > 0 && -b > math.MaxInt64-a) || (a < 0 && -b < math.MinInt64-a)

Check List

Tests

• Unit test

Release note

• separated signatures for builtin MinusIntSig

[Tjianke]

/run-all-tests

[Tjianke]

/run-all-tests

[Tjianke]

/run-tics-test

[Tjianke]

Not sure what's wrong in tics-test, it suggets ERROR 1105 (HY000) at line 1: [FLASH:Coprocessor:Unimplemented] Unspecified is not supported.

/cc @breeswish @XuHuaiyu could you please take a look at this, btw is tics-test available to run in local dev environment?

[Tjianke]

/run-all-tests

[Tjianke]

Depends on TiFlash to implement push down func

[breezewish]

Thanks for the remind. Let's wait TiFlash to implement these separated signatures first.

[breezewish]

Hi, considering that this PR mainly contains two parts:

1. Logic separation, for performance improvements (this need to wait TiFlash)
2. Bug fix (this need to be cherry picked to release branches)

Could you first open a PR to fix bugs? I think this can be merged pretty quickly, since it doesn't need to wait TiFlash.

[Tjianke]

Hi, considering that this PR mainly contains two parts:

1. Logic separation, for performance improvements (this need to wait TiFlash)
2. Bug fix (this need to be cherry picked to release branches)

Could you first open a PR to fix bugs? I think this can be merged pretty quickly, since it doesn't need to wait TiFlash.

Here's the bug-fixing PR(#22426).

[ti-chi-bot]

@Tjianke: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: Patch coverage is 69.52790% with 71 lines in your changes missing coverage. Please review.

Project coverage is 77.0910%. Comparing base (42edd7a) to head (a1c126a).
Report is 13001 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #22163        +/-   ##
================================================
- Coverage   77.1165%   77.0910%   -0.0255%     
================================================
  Files           573        573                
  Lines        146429     146598       +169     
================================================
+ Hits         112921     113014        +93     
- Misses        23347      23391        +44     
- Partials      10161      10193        +32