Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Error message is inconsistent with MySQL when execute insert into operationn #24938

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yuqi1129
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #24927

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@yuqi1129 yuqi1129 requested a review from a team as a code owner May 27, 2021 11:39
@yuqi1129 yuqi1129 requested review from lzmhhh123 and removed request for a team May 27, 2021 11:39
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2021
@yuqi1129 yuqi1129 force-pushed the fix_insert_select branch from 95e7815 to 2035786 Compare May 27, 2021 11:48
@github-actions github-actions bot added the sig/execution SIG execution label May 27, 2021
@yuqi1129 yuqi1129 marked this pull request as draft May 28, 2021 06:15
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2021
@lzmhhh123 lzmhhh123 removed their request for review July 5, 2021 02:09
Comment on lines +521 to +522
if er := e.handleErr(nil, &vals[i], 0, err); er != nil {
return nil, er
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if er := e.handleErr(nil, &vals[i], 0, err); er != nil {
return nil, er
if err := e.handleErr(nil, &vals[i], 0, err); err != nil {
return nil, err

Is this PR ready for review?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun, Thanks for your attention, this problem is quite minor and bearable currently. so in the near future, i will pay no attention on it and it's still in draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

executor: Error message is inconsistent with MySQL when execute insert into operationn
3 participants