-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Error message is inconsistent with MySQL when execute insert into operationn #24938
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
…t into operationn
95e7815
to
2035786
Compare
if er := e.handleErr(nil, &vals[i], 0, err); er != nil { | ||
return nil, er |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if er := e.handleErr(nil, &vals[i], 0, err); er != nil { | |
return nil, er | |
if err := e.handleErr(nil, &vals[i], 0, err); err != nil { | |
return nil, err |
Is this PR ready for review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisonkun, Thanks for your attention, this problem is quite minor and bearable currently. so in the near future, i will pay no attention on it and it's still in draft.
What problem does this PR solve?
Issue Number: close #24927
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Side effects
Release note
No release note