Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: seperate the operation of updateClusterState from the process of job scheduler #55747

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joccau
Copy link
Member

@joccau joccau commented Aug 29, 2024

What problem does this PR solve?

Issue Number: close #55749

Problem Summary:
As title~.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

seperate the operation of udpateClusterState from the process of scheduler job

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2024
Copy link

ti-chi-bot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.5286%. Comparing base (df02db0) to head (5d20cb1).
Report is 571 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55747         +/-   ##
=================================================
- Coverage   72.9210%   56.5286%   -16.3924%     
=================================================
  Files          1585       1734        +149     
  Lines        443451     623627     +180176     
=================================================
+ Hits         323369     352528      +29159     
- Misses       100237     246550     +146313     
- Partials      19845      24549       +4704     
Flag Coverage Δ
integration 25.2915% <80.4878%> (?)
unit 71.9402% <73.1707%> (-0.1102%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.8827% <ø> (+17.4313%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Aug 29, 2024
@joccau joccau force-pushed the seperate-update-clusterstate branch from a37bcfb to afadf92 Compare August 29, 2024 12:49
Signed-off-by: joccau <[email protected]>
@joccau joccau force-pushed the seperate-update-clusterstate branch from afadf92 to be1df2f Compare August 29, 2024 13:00
@joccau joccau requested a review from D3Hunter August 29, 2024 13:00
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 29, 2024
@lance6716 lance6716 changed the title ddl: seperate the operation of udpateClusterState from the process of job scheduler ddl: seperate the operation of updateClusterState from the process of job scheduler Aug 30, 2024
@joccau joccau force-pushed the seperate-update-clusterstate branch from fd5fa27 to 447dc54 Compare August 30, 2024 13:22
@joccau joccau force-pushed the seperate-update-clusterstate branch from 447dc54 to 5d20cb1 Compare September 2, 2024 11:45
@joccau
Copy link
Member Author

joccau commented Sep 3, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

@joccau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 5d20cb1 link true /test check-dev
pull-lightning-integration-test 5d20cb1 link true /test pull-lightning-integration-test
pull-unit-test-ddlv1 5d20cb1 link true /test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seperate the operation of udpateClusterState from the process of job scheduler
2 participants