Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support pre-split index regions before creating index (#57553) #58541

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57553

What problem does this PR solve?

Issue Number: close #57552, close #57551

Problem Summary:

See #57552.

What changed and how does it work?

  • Support specifying the split option in the index option at parser.
  • Split the target index region by keys or ranges before data reorganization when adding an index.
  • Extract common code and tests from pkg/executor/split.go to pkg/util/split.go.
  • Add two functional tests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 26, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 26.04651% with 318 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@738a65b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #58541   +/-   ##
================================================
  Coverage               ?   72.0891%           
================================================
  Files                  ?       1419           
  Lines                  ?     413699           
  Branches               ?          0           
================================================
  Hits                   ?     298232           
  Misses                 ?      95447           
  Partials               ?      20020           
Flag Coverage Δ
unit 72.0891% <26.0465%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5087% <0.0000%> (?)

@tangenta
Copy link
Contributor

/retest

@tangenta
Copy link
Contributor

/retest

1 similar comment
@tangenta
Copy link
Contributor

tangenta commented Jan 7, 2025

/retest

Copy link

ti-chi-bot bot commented Feb 5, 2025

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 25, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 28, 2025
Copy link

ti-chi-bot bot commented Feb 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 08:56:52.027971691 +0000 UTC m=+518959.981129958: ☑️ agreed by Benjamin2037.
  • 2025-02-28 06:26:11.141007295 +0000 UTC m=+596319.094165562: ☑️ agreed by fzzf678.

Copy link

ti-chi-bot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037, benmeadowcroft, fzzf678, tangenta
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta and additionally assign d3hunter, easonn7 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 28, 2025
@ti-chi-bot ti-chi-bot closed this Feb 28, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants