Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade to the latest client-go #59757

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 25, 2025

What problem does this PR solve?

Issue Number: ref #58780

Problem Summary:

What changed and how does it work?

Upgrade the client-go dependency to fix tikv/client-go#1593

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Trigger circuit breaker
8d6115ea-4a81-4eda-af02-98a544723e4b

After 10s cool-down interval, it recovers
df3a965b-eb0e-4604-8fe9-5ad974530e17

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

Signed-off-by: Ryan Leung <[email protected]>
Copy link

ti-chi-bot bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.4532%. Comparing base (03f4a2e) to head (1de7573).
Report is 19 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59757        +/-   ##
================================================
+ Coverage   72.9587%   73.4532%   +0.4944%     
================================================
  Files          1697       1699         +2     
  Lines        468969     473639      +4670     
================================================
+ Hits         342154     347903      +5749     
+ Misses       105748     104489      -1259     
- Partials      21067      21247       +180     
Flag Coverage Δ
unit 72.1513% <80.0000%> (-0.0108%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0084% <ø> (-0.0685%) ⬇️

@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
Signed-off-by: you06 <[email protected]>
@you06
Copy link
Contributor

you06 commented Feb 27, 2025

/retest

@you06
Copy link
Contributor

you06 commented Feb 27, 2025

/retest

Copy link

ti-chi-bot bot commented Feb 27, 2025

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 1de7573 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants