update tipb to make it compatible with tidb #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windtalker
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1363
Problem Summary:
TiDB add some ScalarFuncSigs for minus and divide expression, since TiFlash support expr pushdown for these two expression, we need to update the tipb make TiFlash compatible with the change, otherwise, related TiDB pr will never get merged because tics test always failed.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Support newly added ScalarFuncSigs. Note the behavior of
minusandintDivis not changed, which means we still might have compatibility issues forminusandintDiv, but this pr is enough to un-block TiDB pr.Related changes
Check List
Tests
Side effects
Release note