Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push down ROUND(x, d) #2625

Merged
merged 33 commits into from
Aug 18, 2021
Merged

Push down ROUND(x, d) #2625

merged 33 commits into from
Aug 18, 2021

Conversation

riteme
Copy link
Contributor

@riteme riteme commented Aug 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #2550, close #2426

Problem Summary: enable ROUND(x, d).

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note 

Support pushing down `ROUND(x, d)` to TiFlash.

@riteme riteme added type/enhancement The issue or PR belongs to an enhancement. component/expression labels Aug 7, 2021
@riteme riteme self-assigned this Aug 7, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 9, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2021
@riteme riteme changed the title [DNM] Push down ROUND(x, d) Push down ROUND(x, d) Aug 12, 2021
@riteme
Copy link
Contributor Author

riteme commented Aug 12, 2021

/run-all-tests

@riteme
Copy link
Contributor Author

riteme commented Aug 12, 2021

/run-all-tests

fuzhe1989
fuzhe1989 reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@fuzhe1989 fuzhe1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finished yet ...

fuzhe1989
fuzhe1989 reviewed Aug 14, 2021
View reviewed changes
fuzhe1989
fuzhe1989 reviewed Aug 15, 2021
View reviewed changes
@riteme riteme requested a review from fuzhe1989 August 16, 2021 03:05
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@fuzhe1989
Copy link
Contributor

/run-all-tests

2 similar comments
@fuzhe1989
Copy link
Contributor

/run-all-tests

@fuzhe1989
Copy link
Contributor

/run-all-tests

@riteme
Copy link
Contributor Author

riteme commented Aug 18, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2021
@riteme
Copy link
Contributor Author

riteme commented Aug 18, 2021

/run-all-tests

@riteme
Copy link
Contributor Author

riteme commented Aug 18, 2021

/merge

@ti-chi-bot
Copy link
Member

@riteme: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 57a2f25

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@ti-chi-bot ti-chi-bot merged commit 240ef77 into pingcap:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees
No one assigned
Labels
component/expression release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push down function ROUND(x, d) Push down ROUND() on Decimal types
3 participants
@riteme @ti-chi-bot @fuzhe1989