Support remove region by ps-ctl #9807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Neo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Calvin Neo <[email protected]>
CalvinNeo
changed the title
ti-chi-bot
bot
requested review from
JaySon-Huang,
JinheLin and
Lloyd-Pottiger
Lloyd-Pottiger
approved these changes
Feb 13, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
In what scenarios can this function be used？ |
Recover from the large txn, which include the following steps:
By deleting all regions in KVStore, we can skip those broken regions while restoring. While its proxy counterpart would be removed through gc messages. |
Co-authored-by: JaySon <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
…o support-remove-region
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
approved these changes
Feb 17, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9722
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note