Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect value of the max thread size (#9881) #9882

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9881

What problem does this PR solve?

Issue Number: close #9880, ref #9745

Problem Summary:

See the issue. We make setAuto not static as a workaround. However, we have to handle the coupling of Proxy and Settings.h.

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Feb 18, 2025
@ti-chi-bot
Copy link
Member Author

@CalvinNeo This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2025
Signed-off-by: Calvin Neo <[email protected]>
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 18, 2025
@CalvinNeo
Copy link
Member

/hold

Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2025
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
f
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member

[2025/02/18 12:53:36.798 +08:00] [INFO] [Server.cpp:1117] ["wait for tiflash proxy initializing"] [thread_id=1]
[2025/02/18 12:53:37.198 +08:00] [INFO] [Server.cpp:1120] ["tiflash proxy is initialized"] [thread_id=1]
[2025/02/18 12:53:37.216 +08:00] [ERROR] [BaseDaemon.cpp:367] [########################################] [source=BaseDaemon] [thread_id=2]
[2025/02/18 12:53:37.216 +08:00] [ERROR] [BaseDaemon.cpp:368] ["(from thread 1) Received signal Segmentation fault(11)."] [source=BaseDaemon] [thread_id=2]
[2025/02/18 12:53:37.216 +08:00] [ERROR] [BaseDaemon.cpp:398] ["Address: 0x7ffe0056b720"] [source=BaseDaemon] [thread_id=2]
[2025/02/18 12:53:37.216 +08:00] [ERROR] [BaseDaemon.cpp:404] ["Access: read."] [source=BaseDaemon] [thread_id=2]
[2025/02/18 12:53:37.216 +08:00] [ERROR] [BaseDaemon.cpp:410] ["Attempted access has violated the permissions assigned to the memory area."] [source=BaseDaemon] [thread_id=2]
[2025/02/18 12:53:37.357 +08:00] [ERROR] [BaseDaemon.cpp:560] ["\n       0xc8bc34b\tfaultSignalHandler(int, siginfo_t*, void*) [tiflash+210486091]\n  0x7f86190e9630\t<unknown symbol> [libpthread.so.0+63024]\n  0x7ffe0056b720\t<unknown symbol>\n       0x441124c\tDB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) [tiflash+71373388]\n       0xf9f5945\tPoco::Util::Application::run() [tiflash+262101317]\n       0xfa11915\tPoco::Util::ServerApplication::run() [tiflash+262215957]\n       0x440bd97\tDB::Server::run() [tiflash+71351703]\n       0xfa11af3\tPoco::Util::ServerApplication::run(int, char**) [tiflash+262216435]\n       0x441c438\tmainEntryClickHouseServer(int, char**) [tiflash+71418936]\n       0x42c1951\tmain [tiflash+69998929]\n  0x7f8618914555\t__libc_start_main [libc.so.6+140629]"] [source=BaseDaemon] [thread_id=2]

Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member

/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_segment_read_task.cpp:468: Failure
Expected equality of these values:
  persist_set_wn->getColumnFileCount()
    Which is: 5
  4

Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo
Copy link
Member

/cc @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested a review from JaySon-Huang February 18, 2025 10:14
Comment on lines +1081 to +1083
global_context->setApplicationType(Context::ApplicationType::SERVER);
global_context->getSharedContextDisagg()->disaggregated_mode = disaggregated_mode;
global_context->getSharedContextDisagg()->use_autoscaler = use_autoscaler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pick the change of #9886

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-18 03:01:29.303072687 +0000 UTC m=+930331.699294743: ☑️ agreed by CalvinNeo.
  • 2025-02-18 10:23:37.726874383 +0000 UTC m=+956860.123096445: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit bdb33ae into pingcap:release-8.1 Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants