-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the incorrect value of the max thread size (#9881) #9882
Fix the incorrect value of the max thread size (#9881) #9882
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@CalvinNeo This PR has conflicts, I have hold it. |
Signed-off-by: Calvin Neo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold |
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
/unhold |
Signed-off-by: Calvin Neo <[email protected]>
/hold |
Signed-off-by: Calvin Neo <[email protected]>
|
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
|
Signed-off-by: Calvin Neo <[email protected]>
/cc @JaySon-Huang |
Signed-off-by: JaySon-Huang <[email protected]>
global_context->setApplicationType(Context::ApplicationType::SERVER); | ||
global_context->getSharedContextDisagg()->disaggregated_mode = disaggregated_mode; | ||
global_context->getSharedContextDisagg()->use_autoscaler = use_autoscaler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also pick the change of #9886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
This is an automated cherry-pick of #9881
What problem does this PR solve?
Issue Number: close #9880, ref #9745
Problem Summary:
See the issue. We make
setAuto
not static as a workaround. However, we have to handle the coupling of Proxy and Settings.h.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note