Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config AutoSyncInterval to etcd client #11996

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Jan 13, 2025

What problem does this PR solve?

Issue Number: close #11997

What is changed and how it works?

Add AutoSyncInterval to etcd client which is accidentally removed by #9661

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 13, 2025
@lidezhu lidezhu changed the title add AutoSyncInterval to etcd client config AutoSyncInterval to etcd client Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.2950%. Comparing base (dec6591) to head (270b57d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.7425% <0.0000%> (+0.0035%) ⬆️
dm 50.1516% <ø> (+0.0230%) ⬆️
engine 53.2392% <ø> (+0.0225%) ⬆️
Flag Coverage Δ
unit 55.2950% <0.0000%> (+0.0129%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11996        +/-   ##
================================================
+ Coverage   55.2821%   55.2950%   +0.0129%     
================================================
  Files          1028       1028                
  Lines        142726     142727         +1     
================================================
+ Hits          78902      78921        +19     
+ Misses        58056      58041        -15     
+ Partials       5768       5765         -3     

@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 13, 2025

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-14 01:49:50.8180095 +0000 UTC m=+836734.106841206: ☑️ agreed by asddongmen.
  • 2025-01-14 01:50:33.901935344 +0000 UTC m=+836777.190767049: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot merged commit 5b4b44e into master Jan 14, 2025
27 of 28 checks passed
@ti-chi-bot ti-chi-bot bot deleted the add-auto-sync-interval branch January 14, 2025 01:53
@lidezhu lidezhu added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 14, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 14, 2025

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11998.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11999.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #12000.

@lidezhu lidezhu added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jan 14, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 14, 2025

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #12001.

@lidezhu lidezhu added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 14, 2025
@lidezhu
Copy link
Collaborator Author

lidezhu commented Jan 14, 2025

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc fail to observe pd leader migration
4 participants