Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function signatures for separation of arithmetic functions #206

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Add function signatures for separation of arithmetic functions #206

merged 2 commits into from
Jan 12, 2021

Conversation

Tjianke
Copy link
Contributor

@Tjianke Tjianke commented Jan 3, 2021

Please refer to tidb issue 13979 and tidb issue 13976 for details

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Tjianke
add sig
e2b3a20 
fix formatting
@Tjianke
Copy link
Contributor Author

Tjianke commented Jan 5, 2021 •
edited
Loading

@breeswish PTAL, thanks, I'm working on separation of remaining arithmetic func sigs(minus and divide)

breezewish
breezewish approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@breezewish
Copy link
Member

@ichn-hu PTAL

@Tjianke
Copy link
Contributor Author

Tjianke commented Jan 8, 2021

@breeswish It seems that you need to sign CLA as well

@breezewish breezewish merged commit a8cb6df into pingcap:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tjianke @CLAassistant @breezewish