Skip to content

feat(codex): add reasoning off option#2448

Open
maria-rcks wants to merge 1 commit intopingdotgg:mainfrom
maria-rcks:feat/codex-reasoning-off
Open

feat(codex): add reasoning off option#2448
maria-rcks wants to merge 1 commit intopingdotgg:mainfrom
maria-rcks:feat/codex-reasoning-off

Conversation

@maria-rcks
Copy link
Copy Markdown
Collaborator

@maria-rcks maria-rcks commented May 1, 2026

What Changed

Adds an Off option to the Codex reasoning picker for reasoning-capable models when the Codex app-server model list does not advertise the none effort.

The underlying protocol value remains none; only the UI label is shown as Off.

Why

The Codex app-server schema accepts reasoning_effort: "none", and t3code already forwards selected reasoning effort values. This makes the existing picker able to disable reasoning without adding new UI or changing dispatch behavior.

UI Changes

This changes the Codex reasoning picker options by showing Off.

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: changes only affect how reasoning-effort options are labeled and populated for Codex models, without altering request/dispatch semantics.

Overview
Updates the Codex model capability mapping to always offer a reasoning-disable option by injecting the none effort when a model advertises reasoning efforts but omits it.

Renames the none reasoning effort label from "None" to "Off", while keeping the underlying protocol value as none and preserving default selection behavior.

Reviewed by Cursor Bugbot for commit 662a1eb. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add 'Off' reasoning effort option to Codex model capabilities

  • Renames the none reasoning effort label from 'None' to 'Off' in REASONING_EFFORT_LABELS.
  • Updates mapCodexModelCapabilities in CodexProvider.ts to always inject a none effort option when a model exposes at least one reasoning effort but omits none.
  • The default option continues to be derived from model.defaultReasoningEffort.

Macroscope summarized 662a1eb.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5b4570c1-29d4-4485-a3ff-8d6e1a9a49dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels May 1, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 1, 2026

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature by adding a 'none' (labeled 'Off') reasoning effort option for models that didn't previously expose it. Changes that add new user-facing behavior warrant human review.

You can customize Macroscope's approvability policy. Learn more.

@maria-rcks maria-rcks force-pushed the feat/codex-reasoning-off branch from 7dc374b to 662a1eb Compare May 1, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant