feat(codex): add reasoning off option#2448
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing feature by adding a 'none' (labeled 'Off') reasoning effort option for models that didn't previously expose it. Changes that add new user-facing behavior warrant human review. You can customize Macroscope's approvability policy. Learn more. |
7dc374b to
662a1eb
Compare
What Changed
Adds an
Offoption to the Codex reasoning picker for reasoning-capable models when the Codex app-server model list does not advertise thenoneeffort.The underlying protocol value remains
none; only the UI label is shown asOff.Why
The Codex app-server schema accepts
reasoning_effort: "none", and t3code already forwards selected reasoning effort values. This makes the existing picker able to disable reasoning without adding new UI or changing dispatch behavior.UI Changes
This changes the Codex reasoning picker options by showing
Off.Checklist
Note
Low Risk
Low risk: changes only affect how reasoning-effort options are labeled and populated for Codex models, without altering request/dispatch semantics.
Overview
Updates the Codex model capability mapping to always offer a reasoning-disable option by injecting the
noneeffort when a model advertises reasoning efforts but omits it.Renames the
nonereasoning effort label from "None" to "Off", while keeping the underlying protocol value asnoneand preserving default selection behavior.Reviewed by Cursor Bugbot for commit 662a1eb. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add 'Off' reasoning effort option to Codex model capabilities
nonereasoning effort label from'None'to'Off'inREASONING_EFFORT_LABELS.mapCodexModelCapabilitiesin CodexProvider.ts to always inject anoneeffort option when a model exposes at least one reasoning effort but omitsnone.model.defaultReasoningEffort.Macroscope summarized 662a1eb.