feat: ios16 support#2469
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR updates a vendored native iOS library (GhosttyKit) with iOS 16 compatibility patches. Vendored binary updates cannot be fully verified through code review alone, and this enables new platform support, warranting human review. You can customize Macroscope's approvability policy. Learn more. |
What Changed
Adds ios 16 support to the GhosttyKit library used in mobile app
Why
So we support ios 16
Checklist
Note
Medium Risk
Updates a vendored native terminal rendering framework and its C/Swift integration points, which could introduce runtime/ABI issues on iOS if the new Ghostty build diverges. Dependency/lockfile changes (adding
shiki) also affect build output and dependency resolution.Overview
Adds iOS 16 support for the mobile terminal by switching the vendored
GhosttyKit.xcframeworkto a new fork/revision and updating the vendoredghostty.hAPI surface (notably addingGHOSTTY_APIvisibility macros and changingread_clipboard_cbto returnbool).Updates
T3TerminalView.swiftto match the new callback signature, refreshes Ghostty vendoring/license docs, and introducesscripts/build-libghostty-ios16.shto rebuild and replace the iOS slices/headers ofGhosttyKit.xcframework. Also pins[email protected]inapps/mobile/package.jsonwith correspondingbun.lockupdates.Reviewed by Cursor Bugbot for commit 2e04b58. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add iOS 16 support to the mobile terminal using a custom Ghostty fork
GhosttyKit.xcframeworkto a custom-I/O fork of Ghostty with an iOS 16 compatibility patch (revisiond36c3b8).build-libghostty-ios16.sh, a script to rebuild the xcframework from source using Zig 0.15.2, replacing only theios-arm64andios-arm64-simulatorslices.T3TerminalView.swiftto returnfalsefrom theread_clipboard_cbclosure to match the updatedghostty_runtime_read_clipboard_cbsignature (changed fromvoidtobool).[email protected]as a dependency and updates the lockfile with scoped resolutions to avoid conflicts with packages expecting[email protected].Macroscope summarized 2e04b58.