Skip to content

fix(skills): Fix skill tagging inconsistency between $ and / across providers#2470

Open
AntonVishal wants to merge 1 commit intopingdotgg:mainfrom
AntonVishal:main
Open

fix(skills): Fix skill tagging inconsistency between $ and / across providers#2470
AntonVishal wants to merge 1 commit intopingdotgg:mainfrom
AntonVishal:main

Conversation

@AntonVishal
Copy link
Copy Markdown

@AntonVishal AntonVishal commented May 2, 2026

What Changed

Fixed inconsistent skill tagging between $ and /
Enabled $ parsing for Claude (was not working)
Aligned behavior so multiple skill tags work consistently across providers

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Fix skill tagging inconsistency by deriving Claude provider skills from slash commands

  • Adds claudeSlashCommandsAsProviderSkills helper in claudeSlashCommandsAsProviderSkills.ts that maps slash commands to ServerProviderSkill objects with stable, URL-encoded paths (claude-agent:///slash-command/<name>).
  • Updates checkClaudeProviderStatus in ClaudeProvider.ts to pass the derived skills array to buildServerProvider, replacing prior inconsistent tagging behavior.
  • Skills are always set to enabled=true with scope="claude-agent", and description/shortDescription are populated from slash command fields when present.

Macroscope summarized 633533f.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 91554898-17be-4f77-ba1c-729002ffbe2a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels May 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 2, 2026

Approvability

Verdict: Needs human review

This PR enables new user-facing functionality (the $ skill picker for Claude) by populating skills data that wasn't previously present. While the code is straightforward, enabling new capabilities warrants human review.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant