DEV#2705
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 50f2794. Configure here.
| needs.deploy_web.result == 'success' && | ||
| (needs.finalize.result == 'success' || needs.finalize.result == 'skipped') | ||
| needs: [preflight, release, deploy_web, finalize] | ||
| runs-on: blacksmith-8vcpu-ubuntu-2404 |
There was a problem hiding this comment.
Discord announcement blocked when web deploy is skipped
Medium Severity
The deploy_web job is now gated by vars.DEPLOY_HOSTED_WEB == 'true', meaning it can be skipped. However, announce_discord requires needs.deploy_web.result == 'success' without also accepting 'skipped'. When the web deploy feature flag is disabled, Discord announcements will never run. The finalize dependency is correctly handled with (needs.finalize.result == 'success' || needs.finalize.result == 'skipped') but the same pattern wasn't applied to deploy_web.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 50f2794. Configure here.
ApprovabilityVerdict: Needs human review This PR makes significant changes to the release workflow including switching the source branch from main to dev, changing permissions, replacing runner infrastructure, and adding multiple feature flag gates. Additionally, there is an unresolved review comment identifying a bug where Discord announcements will be blocked when web deploy is disabled. You can customize Macroscope's approvability policy. Learn more. |


What Changed
Why
UI Changes
Checklist
Note
Medium Risk
Changes the GitHub Actions release pipeline triggers, permissions, and tokens, which can affect what gets released and who can publish artifacts. Risk is moderate because it’s CI-only but impacts release automation for desktop/CLI/web deployments.
Overview
The
ReleaseGitHub Actions workflow is retargeted to usedevas the release source branch (including scheduled nightlies), with a resolvedrefpropagated through build/release steps and updated nightly change detection.Publishing is made more configurable:
publish_cli,deploy_web,finalize, and Discord announcements now run only when correspondingvars.*flags are set. The workflow also switches to standard GitHub-hosted runners, usescontents: write, and publishes releases withgithub.tokeninstead of a minted GitHub App token (while version-bump commits still use the app token).Reviewed by Cursor Bugbot for commit 50f2794. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Configure release workflow to trigger on dev branch pushes with repository variable gates
devas a push trigger and setsT3CODE_RELEASE_SOURCE_BRANCH=devso all checkout, tagging, and finalization steps target the dev branch instead of main.ubuntu-24.04,macos-15,windows-2025).publish_cli,deploy_web,finalize,announce_discord) behind repository variables so they can be selectively enabled per environment.releasejob withgithub.token, and removes thepublish_clidependency from the release job so it proceeds even if CLI publishing is skipped.devbranch rather thanmainwhenFINALIZE_STABLE_RELEASEis true.Macroscope summarized 50f2794.