Skip to content

DEV#2705

Closed
samjandris wants to merge 1 commit into
pingdotgg:mainfrom
samjandris:dev
Closed

DEV#2705
samjandris wants to merge 1 commit into
pingdotgg:mainfrom
samjandris:dev

Conversation

@samjandris
Copy link
Copy Markdown

@samjandris samjandris commented May 14, 2026

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes the GitHub Actions release pipeline triggers, permissions, and tokens, which can affect what gets released and who can publish artifacts. Risk is moderate because it’s CI-only but impacts release automation for desktop/CLI/web deployments.

Overview
The Release GitHub Actions workflow is retargeted to use dev as the release source branch (including scheduled nightlies), with a resolved ref propagated through build/release steps and updated nightly change detection.

Publishing is made more configurable: publish_cli, deploy_web, finalize, and Discord announcements now run only when corresponding vars.* flags are set. The workflow also switches to standard GitHub-hosted runners, uses contents: write, and publishes releases with github.token instead of a minted GitHub App token (while version-bump commits still use the app token).

Reviewed by Cursor Bugbot for commit 50f2794. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Configure release workflow to trigger on dev branch pushes with repository variable gates

  • Adds dev as a push trigger and sets T3CODE_RELEASE_SOURCE_BRANCH=dev so all checkout, tagging, and finalization steps target the dev branch instead of main.
  • Switches all job runners from custom Blacksmith runners to standard GitHub-hosted runners (ubuntu-24.04, macos-15, windows-2025).
  • Gates optional jobs (publish_cli, deploy_web, finalize, announce_discord) behind repository variables so they can be selectively enabled per environment.
  • Replaces GitHub App token minting in the release job with github.token, and removes the publish_cli dependency from the release job so it proceeds even if CLI publishing is skipped.
  • Behavioral Change: version bump commits are now pushed to the dev branch rather than main when FINALIZE_STABLE_RELEASE is true.

Macroscope summarized 50f2794.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels May 14, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 299555cd-43d4-4db6-8c12-92eb23a45f7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 50f2794. Configure here.

needs.deploy_web.result == 'success' &&
(needs.finalize.result == 'success' || needs.finalize.result == 'skipped')
needs: [preflight, release, deploy_web, finalize]
runs-on: blacksmith-8vcpu-ubuntu-2404
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord announcement blocked when web deploy is skipped

Medium Severity

The deploy_web job is now gated by vars.DEPLOY_HOSTED_WEB == 'true', meaning it can be skipped. However, announce_discord requires needs.deploy_web.result == 'success' without also accepting 'skipped'. When the web deploy feature flag is disabled, Discord announcements will never run. The finalize dependency is correctly handled with (needs.finalize.result == 'success' || needs.finalize.result == 'skipped') but the same pattern wasn't applied to deploy_web.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 50f2794. Configure here.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 14, 2026

Approvability

Verdict: Needs human review

This PR makes significant changes to the release workflow including switching the source branch from main to dev, changing permissions, replacing runner infrastructure, and adding multiple feature flag gates. Additionally, there is an unresolved review comment identifying a bug where Discord announcements will be blocked when web deploy is disabled.

You can customize Macroscope's approvability policy. Learn more.

@samjandris samjandris closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant