Skip to content

snowcap: lua: Expose base.signaler#446

Merged
Ottatop merged 1 commit intopinnacle-comp:mainfrom
Ph4ntomas:lua-signaler
Apr 26, 2026
Merged

snowcap: lua: Expose base.signaler#446
Ottatop merged 1 commit intopinnacle-comp:mainfrom
Ph4ntomas:lua-signaler

Conversation

@Ph4ntomas
Copy link
Copy Markdown
Contributor

This PR exposes the signaler from base.

I have a Clock Program that share its signaler with the timer driving it, but I can't port it because the lua's base.signaler is private. (well I can, but it makes luals sad).

In rust, widget can contain a Base object and access that object's signaler.
In lua, all Programs inherit from Base, but the signaler is private.

This PR re-align lua with rust by adding a base:signaler() method, so plugins can share the signaler as a whole if needed.

Copy link
Copy Markdown
Collaborator

@Ottatop Ottatop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ottatop Ottatop merged commit 0caaafb into pinnacle-comp:main Apr 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants