Fix clippy 0.1.97#449
Open
Ph4ntomas wants to merge 2 commits intopinnacle-comp:mainfrom
Open
Conversation
Contributor
Author
|
Uh sorry what? Why are the tests failing on EDIT: I think GH Actions were impacted a bit by the current outage, but I can't restart the Action |
Ph4ntomas
force-pushed
the
fix-clippy-0.1.97
branch
from
f701512 to
e8afbcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following new warning/clippy lint:
Latest rust environment added new warning for float -> f32 coercion as this will become a hard error in the future.
rust-lang/rust#154024
Clippy now complains if an explicit index is used with iterator instead of
enumeratefor 0-based counter),or(n..).zipif the counter isn't 0-based. (clippy::explicit_counter_loop)