Skip to content

Commit

Permalink
fix: make transports.options and transports.level optional (#1831)
Browse files Browse the repository at this point in the history
* fix: make transports.options and transports.level optional

According to https://github.com/pinojs/pino/blob/HEAD/docs/transports.md#v7-transports, the options and level are non-required properties for a transport

* adding test for optional level/options
  • Loading branch information
krosenk729 authored Nov 15, 2023
1 parent 177c786 commit 40bdff5
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pino.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ declare namespace pino {

interface TransportTargetOptions<TransportOptions = Record<string, any>> {
target: string
options: TransportOptions
level: LevelWithSilentOrString
options?: TransportOptions
level?: LevelWithSilentOrString
}

interface TransportBaseOptions<TransportOptions = Record<string, any>> {
Expand Down
17 changes: 17 additions & 0 deletions test/types/pino-transport.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,23 @@ expectType<pino.Logger>(pino({
},
}))

const transportsWithoutOptions = pino.transport({
targets: [
{ target: '#pino/pretty' },
{ target: '#pino/file' }
], levels: { foo: 35 }
})
pino(transports)

expectType<pino.Logger>(pino({
transport: {
targets: [
{ target: '#pino/pretty' },
{ target: '#pino/file' }
], levels: { foo: 35 }
},
}))

const pipelineTransport = pino.transport({
pipeline: [{
target: './my-transform.js'
Expand Down

0 comments on commit 40bdff5

Please sign in to comment.