Merge branch 'main' into forbid-default-log-when-custom-only-used

.github/workflows/ci.yml

@@ -4,13 +4,14 @@ on:
   push:
     branches:
       - main
+      - 'v*'
     paths-ignore:
-        - 'docs/**'
-        - '*.md'
+      - 'docs/**'
+      - '*.md'
   pull_request:
     paths-ignore:
-        - 'docs/**'
-        - '*.md'
+      - 'docs/**'
+      - '*.md'
 
 # This allows a subsequently queued workflow run to interrupt previous runs
 concurrency:
@@ -43,9 +44,9 @@ jobs:
       matrix:
         os: [macOS-latest, windows-latest, ubuntu-latest]
         node-version: [18, 20, 22]
-      exclude:
-        - os: windows-latest
-          node-version: 22
+        exclude:
+          - os: windows-latest
+            node-version: 22
 
     steps:
       - name: Check out repo

CONTRIBUTING.md

@@ -6,6 +6,10 @@ Individuals making significant and valuable contributions are given commit-acces
 
 ## Rules
 
+Before you start coding, please read [Contributing to projects with git](https://jrfom.com/posts/2017/03/08/a-primer-on-contributing-to-projects-with-git/). 
+
+Notice that as long as you don't have commit-access to the project, you have to fork the project and open PRs from the feature branches of the forked project.
+
 There are a few basic ground-rules for contributors:
 
 1. **No `--force` pushes** on `master` or modifying the Git history in any way after a PR has been merged.

benchmarks/basic.bench.js

@@ -5,7 +5,7 @@ const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
 const winston = require('winston')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const loglevel = require('./utils/wrap-log-level')(dest)
 const plogNodeStream = pino(dest)

benchmarks/child-child.bench.js

@@ -3,7 +3,7 @@
 const bench = require('fastbench')
 const pino = require('../')
 const bunyan = require('bunyan')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest).child({ a: 'property' }).child({ sub: 'child' })
 delete require.cache[require.resolve('../')]

benchmarks/child-creation.bench.js

@@ -4,7 +4,7 @@ const bench = require('fastbench')
 const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest)
 const plogDest = pino(pino.destination(('/dev/null')))

benchmarks/child.bench.js

@@ -4,7 +4,7 @@ const bench = require('fastbench')
 const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')('child')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest).child({ a: 'property' })
 delete require.cache[require.resolve('../')]

benchmarks/deep-object.bench.js

@@ -5,7 +5,7 @@ const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
 const winston = require('winston')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest)
 delete require.cache[require.resolve('../')]

benchmarks/internal/just-pino-heavy.bench.js

@@ -2,7 +2,7 @@
 
 const bench = require('fastbench')
 const pino = require('../../')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plog = pino(dest)
 delete require.cache[require.resolve('../../')]

benchmarks/internal/just-pino.bench.js

@@ -2,7 +2,7 @@
 
 const bench = require('fastbench')
 const pino = require('../../')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plog = pino(dest)
 delete require.cache[require.resolve('../../')]

benchmarks/internal/redact.bench.js

@@ -2,7 +2,7 @@
 
 const bench = require('fastbench')
 const pino = require('../../')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plog = pino(dest)
 delete require.cache[require.resolve('../../')]

benchmarks/long-string.bench.js

@@ -5,7 +5,7 @@ const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
 const winston = require('winston')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest)
 delete require.cache[require.resolve('../')]

benchmarks/multi-arg.bench.js

@@ -5,7 +5,7 @@ const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
 const winston = require('winston')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const plogNodeStream = pino(dest)
 delete require.cache[require.resolve('../')]

benchmarks/multistream.js

@@ -3,7 +3,7 @@
 const bench = require('fastbench')
 const bunyan = require('bunyan')
 const pino = require('../')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 
 const tenStreams = [

benchmarks/object.bench.js

@@ -5,7 +5,7 @@ const pino = require('../')
 const bunyan = require('bunyan')
 const bole = require('bole')('bench')
 const winston = require('winston')
-const fs = require('fs')
+const fs = require('node:fs')
 const dest = fs.createWriteStream('/dev/null')
 const loglevel = require('./utils/wrap-log-level')(dest)
 const plogNodeStream = pino(dest)

benchmarks/utils/generate-benchmark-doc.js

@@ -1,6 +1,6 @@
 'use strict'
-const { join } = require('path')
-const { execSync } = require('child_process')
+const { join } = require('node:path')
+const { execSync } = require('node:child_process')
 
 const run = (type) => {
   process.stderr.write(`benchmarking ${type}\n`)

benchmarks/utils/runbench.js

@@ -1,8 +1,8 @@
 'use strict'
 
-const { type, platform, arch, release, cpus } = require('os')
-const { resolve, join } = require('path')
-const spawn = require('child_process').spawn
+const { type, platform, arch, release, cpus } = require('node:os')
+const { resolve, join } = require('node:path')
+const spawn = require('node:child_process').spawn
 const pump = require('pump')
 const split = require('split2')
 const through = require('through2')

benchmarks/utils/wrap-log-level.js

@@ -1,8 +1,8 @@
 'use strict'
 
-const { readFileSync } = require('fs')
+const { readFileSync } = require('node:fs')
 const vm = require('vm')
-const { join } = require('path')
+const { join } = require('node:path')
 const code = readFileSync(
   join(__dirname, '..', '..', 'node_modules', 'loglevel', 'lib', 'loglevel.js')
 )

browser.js

@@ -112,7 +112,8 @@ function pino (opts) {
     formatters: opts.browser.formatters,
     levels,
     timestamp: getTimeFunction(opts),
-    messageKey: opts.messageKey || 'msg'
+    messageKey: opts.messageKey || 'msg',
+    onChild: opts.onChild || noop
   }
   logger.levels = getLevels(opts)
   logger.level = level
@@ -127,7 +128,7 @@ function pino (opts) {
   logger.serializers = serializers
   logger._serialize = serialize
   logger._stdErrSerialize = stdErrSerialize
-  logger.child = child
+  logger.child = function (...args) { return child.call(this, setOpts, ...args) }
 
   if (transmit) logger._logEvent = createLogEventShape()
 
@@ -156,7 +157,7 @@ function pino (opts) {
     })
   }
 
-  function child (bindings, childOptions) {
+  function child (setOpts, bindings, childOptions) {
     if (!bindings) {
       throw new Error('missing bindings for child Pino')
     }
@@ -194,8 +195,10 @@ function pino (opts) {
 
     // must happen before the level is assigned
     appendChildLogger(this, newLogger)
+    newLogger.child = function (...args) { return child.call(this, setOpts, ...args) }
     // required to actually initialize the logger functions for any given child
     newLogger.level = childOptions.level || this.level // allow level to be set by childOptions
+    setOpts.onChild(newLogger)
 
     return newLogger
   }
@@ -273,8 +276,13 @@ function set (self, opts, rootLogger, level) {
     configurable: true
   })
 
-  if (!opts.transmit && self[level] === noop) {
-    return
+  if (self[level] === noop) {
+    if (!opts.transmit) return
+
+    const transmitLevel = opts.transmit.level || self.level
+    const transmitValue = rootLogger.levels.values[transmitLevel]
+    const methodValue = rootLogger.levels.values[level]
+    if (methodValue < transmitValue) return
   }
 
   // make sure the log format is correct

build/sync-version.js

@@ -1,5 +1,5 @@
-const fs = require('fs')
-const path = require('path')
+const fs = require('node:fs')
+const path = require('node:path')
 const { version } = require('../package.json')
 
 const metaContent = `'use strict'

docs/api.md

@@ -1312,7 +1312,7 @@ Create a stream composed by multiple destination streams and returns an
 object implementing the [MultiStreamRes](#multistreamres) interface.
 
 ```js
-var fs = require('fs')
+var fs = require('node:fs')
 var pino = require('pino')
 var pretty = require('pino-pretty')
 var streams = [

docs/bundling.md

@@ -34,3 +34,7 @@ If you are a Webpack user, you can achieve this with [pino-webpack-plugin](https
 ## Esbuild Plugin
 
 [esbuild-plugin-pino](https://github.com/davipon/esbuild-plugin-pino) is the esbuild plugin to generate extra pino files for bundling.
+
+## Bun Plugin
+
+[bun-plugin-pino](https://github.com/vktrl/bun-plugin-pino) is the Bun plugin to generate extra pino files for bundling.

docs/help.md

@@ -60,7 +60,7 @@ somewhere so the log rotation tool knows where to send the signal.
 
 ```js
 // write the process pid to a well known location for later
-const fs = require('fs')
+const fs = require('node:fs')
 fs.writeFileSync('/var/run/myapp.pid', process.pid)
 
 const dest = pino.destination('/log/file')

docs/transports.md

@@ -25,7 +25,7 @@ flushed as quickly as possible (there is nothing to do).
 A transport is a module that exports a default function that returns a writable stream:
 
 ```js
-import { createWriteStream } from 'fs'
+import { createWriteStream } from 'node:fs'
 
 export default (options) => {
   return createWriteStream(options.destination)
@@ -54,7 +54,7 @@ The exported function can also be async. If we use an async function we can thro
 if the transform could not be opened. As an example:
 
 ```js
-import fs from 'fs'
+import fs from 'node:fs'
 import { once } from 'events'
 export default async (options) => {
   const stream = fs.createWriteStream(options.destination)
@@ -84,8 +84,8 @@ is serialized and injected into the transport worker thread, then passed to the
 This means that the options object can only contain types that are supported by the
 [Structured Clone Algorithm][sca] which is used to (de)serialize objects between threads.
 
-What if we wanted to use both transports, but send only error logs to `some-file-transport` while
-sending all logs to `my-transport.mjs`? We can use the `pino.transport` function's `destinations` option:
+What if we wanted to use both transports, but send only error logs to `my-transport.mjs` while
+sending all logs to `some-file-transport`? We can use the `pino.transport` function's `level` option:
 
 ```js
 const pino = require('pino')
@@ -218,7 +218,7 @@ As an example, the following transport returns a `Transform` stream:
 
 ```js
 import build from 'pino-abstract-transport'
-import { pipeline, Transform } from 'stream'
+import { pipeline, Transform } from 'node:stream'
 export default async function (options) {
   return build(function (source) {
     const myTransportStream = new Transform({
@@ -378,7 +378,7 @@ A legacy Pino "transport" is a supplementary tool that consumes Pino logs.
 Consider the following example for creating a transport:
 
 ```js
-const { pipeline, Writable } = require('stream')
+const { pipeline, Writable } = require('node:stream')
 const split = require('split2')
 
 const myTransportStream = new Writable({

examples/transport.js

@@ -1,8 +1,8 @@
 'use strict'
 
 const pino = require('..')
-const { tmpdir } = require('os')
-const { join } = require('path')
+const { tmpdir } = require('node:os')
+const { join } = require('node:path')
 
 const file = join(tmpdir(), `pino-${process.pid}-example`)
 

file.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const pino = require('./pino')
-const { once } = require('events')
+const { once } = require('node:events')
 
 module.exports = async function (opts = {}) {
   const destOpts = Object.assign({}, opts, { dest: opts.destination || 1, sync: false })

lib/meta.js

@@ -1,3 +1,3 @@
 'use strict'
 
-module.exports = { version: '9.2.1' }
+module.exports = { version: '9.3.2' }

lib/proto.js

@@ -2,7 +2,7 @@
 
 /* eslint no-prototype-builtins: 0 */
 
-const { EventEmitter } = require('events')
+const { EventEmitter } = require('node:events')
 const {
   lsCacheSym,
   levelValSym,