Add asObjectBindingsOnly, allowing write to receive only the bindings as object #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as object This allows to pass the format string and args as is the underlying console when to keep their special handling, for when using `write` to only modify the default way the printing to the console looks rather than writing to an alternate destination entirely. Part of pinojs#1556
mcollina
requested changes
Sep 28, 2024
|
Can. you add some docs? |
|
Can you point me where to add them? Also do consider the naming and the exact semantics of this API, see the issues I opened for what I'm trying to eventually achieve. |
|
https://github.com/pinojs/pino/blob/main/docs/browser.md I think the name is ok. |
jsumners
reviewed
Feb 4, 2025
|
What do you mean? It's a variation of a flag that only exists in the browser version, where the output interface is different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to pass the format string and args as
is the underlying console when to keep their
special handling, for when using
writeto onlymodify the default way the printing to the console
looks rather than writing to an alternate
destination entirely.
The name of the option and its behavior is obviously open for discussion
Part of #1556