Remove the numbers.thrift test file #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ThriftTest.thrift includes constants, so numbers.thrift is now redundant.
|
@jparise I added that because it explicitly tested the issue that came up in #196 where a file containing only constants would cause an error on compile. It turns out that the reason was because no code was being generated for constants, so technically we do now test the underlying issue. I don't feel that strongly about it either way I guess, just wanted to explain why I added it. |
|
Ah, that makes more sense. Let's leave it for now then. I was only removing it because I thought it was entirely redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ThriftTest.thrift includes constants, so numbers.thrift is now
redundant.