Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Add 7 metadataStore methods to Client #5565

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Feb 14, 2025

What this PR does:

as title

Why we need it:

To make it easier for plugin developers to call methods of metadataStore.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc t-kikuc marked this pull request as draft February 14, 2025 12:58
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 26.29%. Comparing base (936879c) to head (522eb4e).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/pipedsdk/client.go 0.00% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5565      +/-   ##
==========================================
- Coverage   26.31%   26.29%   -0.02%     
==========================================
  Files         467      468       +1     
  Lines       50099    50152      +53     
==========================================
+ Hits        13185    13189       +4     
- Misses      35858    35908      +50     
+ Partials     1056     1055       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc marked this pull request as ready for review February 17, 2025 07:58
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit dd9db10 into master Feb 18, 2025
16 of 18 checks passed
@t-kikuc t-kikuc deleted the plugin/sdk/1-client-metadata branch February 18, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants