Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeployTargetConfig and unmarshal config json #5582

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 19, 2025

What this PR does:

  • Add struct DeployTarget to represent deploy targets for plugins.
  • Implement unmarshaling of plugin config

Why we need it:

  • I want the plugin developer to write less code, such as unmarshaling JSON to config struct.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 26.29%. Comparing base (a281dcd) to head (14d1d7f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/pipedsdk/deployment.go 0.00% 34 Missing ⚠️
pkg/plugin/pipedsdk/sdk.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
- Coverage   26.30%   26.29%   -0.01%     
==========================================
  Files         469      469              
  Lines       50323    50337      +14     
==========================================
  Hits        13235    13235              
- Misses      36027    36041      +14     
  Partials     1061     1061              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 19, 2025 00:44
@Warashi Warashi enabled auto-merge (squash) February 19, 2025 02:33
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(It took me a while to underdstand Config, DeployTarget, DeployTargetConfig 😅 )

@Warashi Warashi merged commit 88ec254 into master Feb 19, 2025
16 of 18 checks passed
@Warashi Warashi deleted the modify-sdk-interfaces branch February 19, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants