Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example plugin implementation using SDK #5583

Merged
merged 5 commits into from
Feb 19, 2025
Merged

Add example plugin implementation using SDK #5583

merged 5 commits into from
Feb 19, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 19, 2025

What this PR does:

  • rename pipedsdk to SDK
    • the name pipedsdk is confusing because it's SDK for plugin not piped.
  • add example plugin
  • fix error in config unmarshal
  • implement some methods for PipelineSyncPlugin

Why we need it:

It's nice that we have example implementation

Which issue(s) this PR fixes:

Part of #5529

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi marked this pull request as ready for review February 19, 2025 02:46
@Warashi Warashi enabled auto-merge (squash) February 19, 2025 02:47
@Warashi Warashi merged commit b099bc0 into master Feb 19, 2025
16 checks passed
@Warashi Warashi deleted the dummy-plugin branch February 19, 2025 02:49
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 26.28%. Comparing base (88ec254) to head (90ac919).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/example/plugin.go 0.00% 10 Missing ⚠️
pkg/plugin/sdk/deployment.go 0.00% 8 Missing ⚠️
pkg/app/pipedv1/plugin/example/main.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5583      +/-   ##
==========================================
- Coverage   26.29%   26.28%   -0.02%     
==========================================
  Files         469      471       +2     
  Lines       50337    50359      +22     
==========================================
  Hits        13235    13235              
- Misses      36041    36063      +22     
  Partials     1061     1061              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants