Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine BuildQuickSyncPipelineStages signature in deployment plugin interface #5599

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 21, 2025

What this PR does:

as title

Why we need it:

We need it to provide SDK code for creating QuickSync

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 26.22%. Comparing base (ad00a56) to head (f9ea5b7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 0.00% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5599      +/-   ##
==========================================
- Coverage   26.25%   26.22%   -0.04%     
==========================================
  Files         472      472              
  Lines       50388    50428      +40     
==========================================
- Hits        13230    13224       -6     
- Misses      36097    36143      +46     
  Partials     1061     1061              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit a20eaef into master Feb 25, 2025
16 of 18 checks passed
@ffjlabo ffjlabo deleted the refine-deployment-plugin-interface branch February 25, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants