Implement Livestate SDK #5626
Merged
Implement Livestate SDK #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs in a single method Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…Model Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…l conversions Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5626 +/- ##
==========================================
- Coverage 26.54% 25.56% -0.99%
==========================================
Files 477 477
Lines 50666 50945 +279
==========================================
- Hits 13450 13022 -428
- Misses 36153 36918 +765
+ Partials 1063 1005 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
t-kikuc
reviewed
Mar 6, 2025
| } | ||
|
|
||
| func TestLivestatePluginServer_GetLivestate(t *testing.T) { | ||
| tests := []struct { |
There was a problem hiding this comment.
Thank you. Fixed on this commit.
cc8fb17
Comment on lines
+116
to
+124
| deployTargets := make([]*DeployTarget[DeployTargetConfig], 0, len(request.GetDeployTargets())) | ||
| for _, name := range request.GetDeployTargets() { | ||
| dt, ok := s.deployTargets[name] | ||
| if !ok { | ||
| return nil, status.Errorf(codes.Internal, "the deploy target %s is not found in the piped plugin config", name) | ||
| } | ||
|
|
||
| deployTargets = append(deployTargets, dt) | ||
| } |
There was a problem hiding this comment.
[refactor] Let's convert this block into a function in another PR since the same logic appears in ExecuteStage(), etc.
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
ffjlabo
reviewed
Mar 7, 2025
Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
|
@t-kikuc |
t-kikuc
approved these changes
Mar 10, 2025
ffjlabo
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
To implement the livestate feature with this SDK
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?: No