Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Implement DetermineVersions RPC for DeploymentPlugin #5647

Merged
merged 9 commits into from
Mar 12, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 12, 2025

What this PR does:

This PR implements the DetermineVersions gRPC method for DeploymentPlugin.

Why we need it:

To implement SDK

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi marked this pull request as ready for review March 12, 2025 02:56
@ffjlabo
Copy link
Member

ffjlabo commented Mar 12, 2025

@Warashi Can you check the test result? It seems failed.

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi
Copy link
Contributor Author

Warashi commented Mar 12, 2025

@ffjlabo
Sorry, fixed on this commit
abc09d0

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 24 lines in your changes missing coverage. Please review.

Project coverage is 25.55%. Comparing base (447540b) to head (abc09d0).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 57.69% 22 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5647      +/-   ##
==========================================
+ Coverage   25.53%   25.55%   +0.01%     
==========================================
  Files         477      477              
  Lines       51022    51072      +50     
==========================================
+ Hits        13030    13052      +22     
- Misses      36987    37014      +27     
- Partials     1005     1006       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffjlabo ffjlabo enabled auto-merge (squash) March 12, 2025 04:11
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ffjlabo ffjlabo merged commit d479650 into master Mar 12, 2025
18 checks passed
@ffjlabo ffjlabo deleted the sdk-determine-versions-and-strategy branch March 12, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants