-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Implement DetermineVersions RPC for DeploymentPlugin #5647
Conversation
…ioning Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…se types Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…rsionsResponse to internal models Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Can you check the test result? It seems failed. |
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5647 +/- ##
==========================================
+ Coverage 25.53% 25.55% +0.01%
==========================================
Files 477 477
Lines 51022 51072 +50
==========================================
+ Hits 13030 13052 +22
- Misses 36987 37014 +27
- Partials 1005 1006 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
What this PR does:
This PR implements the DetermineVersions gRPC method for DeploymentPlugin.
Why we need it:
To implement SDK
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?: No